chore: improve spyOn ESM namespace error guidance#9505
Open
brightcat1 wants to merge 5 commits intovitest-dev:mainfrom
Open
chore: improve spyOn ESM namespace error guidance#9505brightcat1 wants to merge 5 commits intovitest-dev:mainfrom
brightcat1 wants to merge 5 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9467
Improve
vi.spyOnerror guidance when spying on native ESM module namespace exports (non-configurable).In Browser Mode, the message now points to the Browser "Spying on Module Exports" limitations section.
In Node/SSR, it instead suggests inlining dependencies via "test.server.deps.inline" and using module mocking docs.
Also updated
docs/guide/migration.mdwith a short v4 migration note for this case.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.docs/guide/migration.md(v4 migration note forvi.spyOnon native ESM namespace exports).Changesets
feat:,fix:,perf:,docs:, orchore:.