Skip to content

Conversation

@leblancmeneses
Copy link

related to: #696

solution is documented in cluster-autoscaler: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/hetzner/README.md

[quote]
HCLOUD_CLUSTER_CONFIG_FILE Can be used as alternative to HCLOUD_CLUSTER_CONFIG.
[/quote]

Switched binary to use HCLOUD_CLUSTER_CONFIG_FILE internally instead.

This is working in my cluster with over 20+ configured node pools.

I tried running the e2e tests but they are not working on main for me after setting up env so it won't work on my branch.

[Configuration] Some information in the configuration file requires your attention, aborting.
[Configuration]  - The number of locations specified for masters must equal the total number of masters
[Configuration]  - All workers must be in valid locations and in the same network zone as the masters when using a private network or etcd datastore
 _          _     

Copy link
Owner

@vitobotta vitobotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR, thanks a lot! I only requested that you remove a permission from Claude Code's settings. I will try to merge and make a release this weekend if I have time.

@vitobotta
Copy link
Owner

And no worries about the e2e tests, they need proper fixing.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants