This repository was archived by the owner on Sep 29, 2023. It is now read-only.
added try/except block so that method handles errors more sanely#199
Open
xnopasaranx wants to merge 1 commit intomasterfrom
Open
added try/except block so that method handles errors more sanely#199xnopasaranx wants to merge 1 commit intomasterfrom
xnopasaranx wants to merge 1 commit intomasterfrom
Conversation
phorward
approved these changes
Jan 16, 2020
Member
phorward
left a comment
phorward
left a comment
There was a problem hiding this comment.
This is useful because I made this fix several times in various projects already.
It seems that there is something wrong with the data, obviously from database transfers to new projects.
The problem won't exist anymore with ViUR 3.0 IMHO, due there is no more blobstore available.
sveneberth
reviewed
Jan 21, 2020
Comment on lines
+468
to
+470
| except Exception as e: | ||
| # logging.exception(e) | ||
| raise e |
Member
There was a problem hiding this comment.
I see no reason for this. Can you remove it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.