Skip to content

Update Final Form (major)#4289

Open
renovate[bot] wants to merge 3 commits intomainfrom
renovate/major-final-form
Open

Update Final Form (major)#4289
renovate[bot] wants to merge 3 commits intomainfrom
renovate/major-final-form

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Aug 6, 2025

This PR contains the following updates:

Package Change Age Confidence
final-form ^4.20.10 -> ^5.0.0 age confidence
final-form ^4.0.0 -> ^4.0.0 || ^5.0.0 age confidence
final-form ^4.16.1 -> ^4.16.1 || ^5.0.0 age confidence
final-form-arrays ^3.1.0 -> ^4.0.0 age confidence
react-final-form ^6.5.9 -> ^7.0.0 age confidence
react-final-form ^6.0.0 -> ^6.0.0 || ^7.0.0 age confidence
react-final-form ^6.3.1 -> ^6.3.1 || ^7.0.0 age confidence
react-final-form-arrays ^3.1.4 -> ^4.0.0 age confidence

Release Notes

final-form/final-form (final-form)

v5.0.0

Compare Source

This release has converted the entire library from Flow to TypeScript.

There should be NO BREAKING CHANGES, but because so much code was touched, I'm bumping to a major version out of precaution.

Read more here: Final Form goes to TypeScript

final-form/final-form-arrays (final-form-arrays)

v4.0.0

Compare Source

This release has converted the entire library from Flow to TypeScript.

There should be NO BREAKING CHANGES, but because so much code was touched, I'm bumping to a major version out of precaution.

Read more here: Final Form goes to TypeScript

final-form/react-final-form (react-final-form)

v7.0.0

Compare Source

This release has converted the entire library from Flow to TypeScript.

There should be NO BREAKING CHANGES, but because so much code was touched, I'm bumping to a major version out of precaution.

Read more here: Final Form goes to TypeScript

final-form/react-final-form-arrays (react-final-form-arrays)

v4.0.0

Compare Source

This release has converted the entire library from Flow to TypeScript.

There should be NO BREAKING CHANGES, but because so much code was touched, I'm bumping to a major version out of precaution.

Read more here: Final Form goes to TypeScript


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/major-final-form branch from d0d37a3 to 972a430 Compare August 6, 2025 07:09
@johnnyomair
Copy link
Collaborator

@manuelblum this should target next.

@renovate renovate bot force-pushed the renovate/major-final-form branch 2 times, most recently from d69b25c to f6972dd Compare August 13, 2025 13:10
@renovate renovate bot force-pushed the renovate/major-final-form branch 2 times, most recently from 0ebdcd2 to 57d7278 Compare August 25, 2025 10:53
@renovate renovate bot force-pushed the renovate/major-final-form branch 2 times, most recently from 5f75c01 to e613619 Compare September 4, 2025 05:50
@renovate renovate bot force-pushed the renovate/major-final-form branch 3 times, most recently from 86c22d7 to b2666b8 Compare September 30, 2025 12:23
@manuelblum manuelblum force-pushed the renovate/major-final-form branch from b2666b8 to bb424e4 Compare September 30, 2025 13:35
@manuelblum
Copy link
Collaborator

looked today into react-final-form update again and had to apply some fixes.

@manuelblum this should target next.

@johnnyomair i am not sure if this is still your opinion, but renovate widen the peer dependency so theoretically this support react-final-form version 6 and 7, and as well final-form 4 and 5.

https://github.com/vivid-planet/comet/pull/4289/files#diff-1985a73d78390732c307c32bc76df1800572801db74af26cf121cde24a35f630R61

https://github.com/vivid-planet/comet/pull/4289/files#diff-67b935f39a664bd301170ae1166e163197025cdf3b94f687e7d9130a7229f7caR69

input,
meta,
fieldContainerProps,
/* TODO: check how to forward rest props to fieldContainer --> fieldContainerProps,*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, if this could cause problems.

This just worked, because FieldRenderProps where typed before:

export interface FieldRenderProps<
  FieldValue,
  T extends HTMLElement = HTMLElement,
  InputValue = FieldValue,
> {
  input: FieldInputProps<InputValue, T>;
  meta: FieldMetaState<FieldValue>;
  [otherProp: string]: any;
}

after

export interface FieldRenderProps<FieldValue = any, T extends HTMLElement = HTMLElement, _FormValues = any> {
    input: FieldInputProps<FieldValue, T>;
    meta: {
        active?: boolean;
        data?: Record<string, any>;
        dirty?: boolean;
        dirtySinceLastSubmit?: boolean;
        error?: any;
        initial?: any;
        invalid?: boolean;
        length?: number;
        modified?: boolean;
        modifiedSinceLastSubmit?: boolean;
        pristine?: boolean;
        submitError?: any;
        submitFailed?: boolean;
        submitSucceeded?: boolean;
        submitting?: boolean;
        touched?: boolean;
        valid?: boolean;
        validating?: boolean;
        visited?: boolean;
    };
}

throw new Error(`Warning: Must specify either a render function as children, or a component prop to ${name}`);
}
return children({ input, meta, disabled, required });
return children({ input, meta /*disabled, required TODO: how to forward disabled and required to fields*/ });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, i am unsure if this causes problems.

@johnnyomair
Copy link
Collaborator

@johnnyomair i am not sure if this is still your opinion, but renovate widen the peer dependency so theoretically this support react-final-form version 6 and 7, and as well final-form 4 and 5.

I'm not confident if our library code would still work with react-final-form 6 and final-form 4 due to the removed props and as casts. We could try this by keeping Demo/Storybook on the older versions.

@johnnyomair johnnyomair self-assigned this Nov 25, 2025
@renovate renovate bot force-pushed the renovate/major-final-form branch from 92c0f92 to 33a4359 Compare November 25, 2025 08:57
@johnnyomair johnnyomair force-pushed the renovate/major-final-form branch from 172e92f to 1bc0bb2 Compare November 25, 2025 12:14
@johnnyomair johnnyomair force-pushed the renovate/major-final-form branch from 1bc0bb2 to f0a67cd Compare November 25, 2025 12:15
@renovate
Copy link
Contributor Author

renovate bot commented Nov 27, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@johnnyomair johnnyomair removed their assignment Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants