Conversation
d0d37a3 to
972a430
Compare
|
@manuelblum this should target next. |
d69b25c to
f6972dd
Compare
0ebdcd2 to
57d7278
Compare
5f75c01 to
e613619
Compare
86c22d7 to
b2666b8
Compare
b2666b8 to
bb424e4
Compare
|
looked today into react-final-form update again and had to apply some fixes.
@johnnyomair i am not sure if this is still your opinion, but renovate widen the peer dependency so theoretically this support react-final-form version 6 and 7, and as well final-form 4 and 5. |
| input, | ||
| meta, | ||
| fieldContainerProps, | ||
| /* TODO: check how to forward rest props to fieldContainer --> fieldContainerProps,*/ |
There was a problem hiding this comment.
I am not sure, if this could cause problems.
This just worked, because FieldRenderProps where typed before:
export interface FieldRenderProps<
FieldValue,
T extends HTMLElement = HTMLElement,
InputValue = FieldValue,
> {
input: FieldInputProps<InputValue, T>;
meta: FieldMetaState<FieldValue>;
[otherProp: string]: any;
}
after
export interface FieldRenderProps<FieldValue = any, T extends HTMLElement = HTMLElement, _FormValues = any> {
input: FieldInputProps<FieldValue, T>;
meta: {
active?: boolean;
data?: Record<string, any>;
dirty?: boolean;
dirtySinceLastSubmit?: boolean;
error?: any;
initial?: any;
invalid?: boolean;
length?: number;
modified?: boolean;
modifiedSinceLastSubmit?: boolean;
pristine?: boolean;
submitError?: any;
submitFailed?: boolean;
submitSucceeded?: boolean;
submitting?: boolean;
touched?: boolean;
valid?: boolean;
validating?: boolean;
visited?: boolean;
};
}
| throw new Error(`Warning: Must specify either a render function as children, or a component prop to ${name}`); | ||
| } | ||
| return children({ input, meta, disabled, required }); | ||
| return children({ input, meta /*disabled, required TODO: how to forward disabled and required to fields*/ }); |
There was a problem hiding this comment.
same here, i am unsure if this causes problems.
I'm not confident if our library code would still work with react-final-form 6 and final-form 4 due to the removed props and as casts. We could try this by keeping Demo/Storybook on the older versions. |
92c0f92 to
33a4359
Compare
172e92f to
1bc0bb2
Compare
1bc0bb2 to
f0a67cd
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
^4.20.10->^5.0.0^4.0.0->^4.0.0 || ^5.0.0^4.16.1->^4.16.1 || ^5.0.0^3.1.0->^4.0.0^6.5.9->^7.0.0^6.0.0->^6.0.0 || ^7.0.0^6.3.1->^6.3.1 || ^7.0.0^3.1.4->^4.0.0Release Notes
final-form/final-form (final-form)
v5.0.0Compare Source
This release has converted the entire library from Flow to TypeScript.
There should be NO BREAKING CHANGES, but because so much code was touched, I'm bumping to a major version out of precaution.
Read more here: Final Form goes to TypeScript
final-form/final-form-arrays (final-form-arrays)
v4.0.0Compare Source
This release has converted the entire library from Flow to TypeScript.
There should be NO BREAKING CHANGES, but because so much code was touched, I'm bumping to a major version out of precaution.
Read more here: Final Form goes to TypeScript
final-form/react-final-form (react-final-form)
v7.0.0Compare Source
This release has converted the entire library from Flow to TypeScript.
There should be NO BREAKING CHANGES, but because so much code was touched, I'm bumping to a major version out of precaution.
Read more here: Final Form goes to TypeScript
final-form/react-final-form-arrays (react-final-form-arrays)
v4.0.0Compare Source
This release has converted the entire library from Flow to TypeScript.
There should be NO BREAKING CHANGES, but because so much code was touched, I'm bumping to a major version out of precaution.
Read more here: Final Form goes to TypeScript
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.