v26.1.5
🔧 Refactoring & Code Quality
Cost Centers Branch
- Improved error handling: Replaced wrapped error messages with direct
diag.FromErr(err)for cleaner error reporting - Better validation: Use
validation.ToDiagFuncdirectly instead of custom wrapper for more idiomatic code - Cleaner optional fields: Use
github.Ptr()for optional fields to go-github API - Stable resource IDs: Use
buildTwoPartID()for consistent ID formatting - Removed redundant code:
- Eliminated unnecessary sorting before TypeSet operations (SDK handles ordering)
- Removed redundant state normalization that duplicated default values
- Improved error messages: More actionable error messages for better debugging
Enterprise SCIM Branch
- Consistent error handling: Replaced ~30 instances of
diag.Errorf("error setting X: %s", err)withdiag.FromErr(err)across 4 files:data_source_github_enterprise_scim_user.go(10 fixes)data_source_github_enterprise_scim_group.go(6 fixes)data_source_github_enterprise_scim_users.go(7 fixes)data_source_github_enterprise_scim_groups.go(7 fixes)
- Simplified validation logic: Removed redundant conditional checks for
startIndexanditemsPerPageparameters
Enterprise Teams Branch
- Improved validation: Use
validation.ToDiagFuncdirectly instead of customtoDiagFuncwrapper fororganization_selection_typefield
✅ Quality Assurance
- All branches tested with acceptance tests before merge
- Build passes with 0 linting issues
- All unit tests passing (4.9s)
- Code follows established best practices from project guidelines
Impact: These changes improve code maintainability, consistency, and debugging experience without changing functionality.
Full Changelog: v26.1.4...v26.1.5