Skip to content

fix(event): Fix Duplicate event notification delivery #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weilaaa merged 1 commit into from
Nov 26, 2025
Merged

fix(event): Fix Duplicate event notification delivery #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 34 additions & 24 deletions veaiops/handler/services/event/subscribe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,40 +93,50 @@ async def create_notice_details(event: Event, subscribes: List[Subscribe]) -> Li
"""
logger.info(f"start create notice details. event_id={event.id} matched_subscribes={subscribes}")
notice_details = []
seen_notifications = set()
for subscribe in subscribes:
# 2.1 Webhook notification
if subscribe.enable_webhook is True and subscribe.webhook_endpoint:
logger.info(f"create notice detail with webhook endpoint {subscribe.webhook_endpoint} meet")
notice_details.append(
EventNoticeDetail(
event_main_id=event.id,
notice_channel=ChannelType.Webhook,
target=subscribe.webhook_endpoint,
extra={"headers": subscribe.webhook_headers},
status=EventStatus.INITIAL,
key = (event.id, ChannelType.Webhook, subscribe.webhook_endpoint)
if key not in seen_notifications:
logger.info(f"create notice detail with webhook endpoint {subscribe.webhook_endpoint} meet")
notice_details.append(
EventNoticeDetail(
event_main_id=event.id,
notice_channel=ChannelType.Webhook,
target=subscribe.webhook_endpoint,
extra={"headers": subscribe.webhook_headers},
status=EventStatus.INITIAL,
)
)
)
seen_notifications.add(key)

# 2.2 Channel notifications
for strategy in subscribe.inform_strategy_ids:
logger.info(f"create notice detail with channel strategy {strategy}")
for chat_id in strategy.chat_ids:
logger.info(
f"create notice detail with channel strategy {strategy} channel{strategy.channel} chat_id {chat_id}"
)
notice_details.append(
EventNoticeDetail(
event_main_id=event.id,
notice_channel=ChannelType(strategy.channel),
target=chat_id,
extra={
"bot_id": strategy.bot_id,
"msg_id": event.raw_data.msg_id if isinstance(event.raw_data, AgentNotification) else "",
"chat_id": chat_id,
},
status=EventStatus.INITIAL,
key = (event.id, ChannelType(strategy.channel), chat_id)
if key not in seen_notifications:
logger.info(
f"create notice detail with channel strategy {strategy} "
f"channel {strategy.channel} chat_id {chat_id}"
)
)
notice_details.append(
EventNoticeDetail(
event_main_id=event.id,
notice_channel=ChannelType(strategy.channel),
target=chat_id,
extra={
"bot_id": strategy.bot_id,
"msg_id": event.raw_data.msg_id
if isinstance(event.raw_data, AgentNotification)
else "",
"chat_id": chat_id,
},
status=EventStatus.INITIAL,
)
)
seen_notifications.add(key)

return notice_details

Expand Down