Skip to content

Filter on lists#5775

Merged
gatesn merged 3 commits intodevelopfrom
ngates/lists
Dec 17, 2025
Merged

Filter on lists#5775
gatesn merged 3 commits intodevelopfrom
ngates/lists

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Dec 17, 2025

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/chore A trivial change label Dec 17, 2025
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from joseph-isaacs December 17, 2025 16:43
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 17, 2025

CodSpeed Performance Report

Merging #5775 will degrade performances by 10.97%

Comparing ngates/lists (269810a) with develop (c93b6a7)

Summary

❌ 16 regressions
✅ 1240 untouched
⏩ 621 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
bench_dict_mask[(0.01, 0.5)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.01, 0.9)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.01, 0.1)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.1, 0.1)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.01, 0.01)] 1 ms 1.1 ms -10.97%
bench_dict_mask[(0.1, 0.01)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.5, 0.5)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.5, 0.1)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.5, 0.01)] 1 ms 1.1 ms -10.97%
bench_dict_mask[(0.5, 0.9)] 1 ms 1.1 ms -10.95%
bench_dict_mask[(0.1, 0.5)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.9, 0.5)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.1, 0.9)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.9, 0.01)] 1 ms 1.1 ms -10.96%
bench_dict_mask[(0.9, 0.9)] 1 ms 1.1 ms -10.9%
bench_dict_mask[(0.9, 0.1)] 1 ms 1.1 ms -10.96%

Footnotes

  1. 621 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 32.74112% with 265 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.02%. Comparing base (c93b6a7) to head (269810a).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-duckdb/src/exporter/list_view.rs 50.95% 103 Missing ⚠️
...rtex-array/src/arrays/list/vtable/kernel/filter.rs 0.00% 65 Missing ⚠️
vortex-array/src/arrays/list/compute/filter.rs 13.51% 32 Missing ⚠️
vortex-array/src/arrays/listview/vtable/rules.rs 0.00% 16 Missing ⚠️
vortex-array/src/arrays/dict/vtable/rules.rs 0.00% 14 Missing ⚠️
vortex-duckdb/src/exporter/list.rs 54.16% 11 Missing ⚠️
vortex-array/src/arrays/list/vtable/mod.rs 0.00% 8 Missing ⚠️
vortex-array/src/arrays/listview/vtable/mod.rs 0.00% 7 Missing ⚠️
vortex-duckdb/src/exporter/mod.rs 50.00% 4 Missing ⚠️
vortex-array/src/arrays/scalar_fn/rules.rs 0.00% 3 Missing ⚠️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@joseph-isaacs joseph-isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add some exporter tests

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) December 17, 2025 19:00
@gatesn gatesn requested a review from joseph-isaacs December 17, 2025 19:00
@gatesn gatesn merged commit baafc71 into develop Dec 17, 2025
46 of 47 checks passed
@gatesn gatesn deleted the ngates/lists branch December 17, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants