Skip to content

Conversation

@blaginin
Copy link
Member

@blaginin blaginin commented Feb 3, 2026

No description provided.

Signed-off-by: blaginin <github@blaginin.me>
@blaginin blaginin requested a review from AdamGS February 3, 2026 14:12
@blaginin blaginin self-assigned this Feb 3, 2026
@blaginin blaginin added the changelog/chore A trivial change label Feb 3, 2026
@blaginin blaginin enabled auto-merge (squash) February 3, 2026 14:12
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing db/pretty-display-fields (da9a5f6) with develop (5886c27)

Summary

✅ 1138 untouched benchmarks
⏩ 1265 skipped benchmarks1

Footnotes

  1. 1265 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@
Signed-off-by: blaginin <github@blaginin.me>
Comment on lines 581 to 603
#[test]
fn test_display_alternate() {
let inner = StructFields::from_iter([
("street", DType::Utf8(Nullability::NonNullable)),
("city", DType::Utf8(Nullability::Nullable)),
]);
let fields = StructFields::from_iter([
("name", DType::Utf8(Nullability::NonNullable)),
("age", DType::Primitive(PType::I32, Nullability::Nullable)),
("address", DType::Struct(inner, Nullability::Nullable)),
]);

assert_snapshot!(format!("{fields:#}"), @"
{
name=utf8,
age=i32?,
address={
street=utf8,
city=utf8?
}?
}
");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you show a larger print with a list and struct

blaginin and others added 2 commits February 4, 2026 13:57
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 4, 2026

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6742d97
Status: ✅  Deploy successful!
Preview URL: https://f670154d.vortex-93b.pages.dev
Branch Preview URL: https://db-pretty-display-fields.vortex-93b.pages.dev

View logs

Signed-off-by: blaginin <github@blaginin.me>
@joseph-isaacs joseph-isaacs added changelog/feature A new feature and removed changelog/chore A trivial change labels Feb 4, 2026
@joseph-isaacs joseph-isaacs changed the title alternate for StructFields feat: alternate for StructFields Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants