shared array in dict layout #6305
Open
+341
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onur Satici <onur@spiraldb.com>
onursatici
added
changelog/fix
github-actions
bot
removed
the
action/benchmark-sql
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Comment on lines
16
to
17
| pub(super) source: ArrayRef, | ||
| pub(super) cache: Arc<OnceLock<Canonical>>, |
Contributor
There was a problem hiding this comment.
Have this be a Arc<RwLock> where enum Shared = Array(ArrayRef) | Cached(Canonical)
Comment on lines
21
to
29
| impl Clone for SharedArray { | ||
| fn clone(&self) -> Self { | ||
| Self { | ||
| source: self.source.clone(), | ||
| cache: Arc::clone(&self.cache), | ||
| stats: self.stats.clone(), | ||
| } | ||
| } | ||
| } |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Comment on lines
40
to
42
| pub fn source(&self) -> &ArrayRef { | ||
| &self.source | ||
| } |
Contributor
There was a problem hiding this comment.
when do you think you ever want this?
Contributor
Author
There was a problem hiding this comment.
yea not much, maybe tests
| } | ||
|
|
||
| fn deserialize(_bytes: &[u8]) -> VortexResult<Self::Metadata> { | ||
| vortex_error::vortex_bail!("Shared array is not serializable") |
Comment on lines
121
to
127
| self.values_evals | ||
| .entry(expr.clone()) | ||
| .or_insert_with(|| { | ||
| self.values_array() | ||
| .map(move |array| { | ||
| let array = array?.apply(&expr)?; | ||
| // We execute the array to avoid re-evaluating for every split. | ||
| let mut ctx = ExecutionCtx::new(session); | ||
| Ok(array.execute::<Canonical>(&mut ctx)?.into_array()) | ||
| Ok(SharedArray::new(array).into_array()) |
Contributor
There was a problem hiding this comment.
this is for a filter and it kind of breaks things?
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we can get read from a DictLayout without executing anything