support search in select component dropdown#70
Merged
Conversation
erik-nieh
requested changes
Feb 10, 2026
src/components/Select/Select.tsx
Outdated
| () => | ||
| query | ||
| ? options?.filter((opt) => | ||
| opt.data.label.toLowerCase().includes(query.toLowerCase()) |
Contributor
There was a problem hiding this comment.
maybe trim() this query too
| onClose={() => setQuery("")} | ||
| > | ||
| <ComboboxInput | ||
| displayValue={getDisplayValue} |
Contributor
There was a problem hiding this comment.
should we be displaying the query to the user?
Contributor
Author
There was a problem hiding this comment.
I think we should show what's currently selected rather than the query itself
erik-nieh
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Select component should allow arrow selection + search among the option dropdown
Changes
Screen.Recording.2026-02-10.at.2.23.43.PM.mov
Testing