Fix loginctl user

[dix2]

Pull Request (PR) description

Use separately map and .to_h instead of block to to_h within loginctl_user resource

This Pull Request (PR) fixes the following issues

Fixes #570

[bastelfreak]

@dix2 there are also some tests in https://github.com/voxpupuli/puppet-systemd/blob/master/spec/unit/puppet/provider/loginctl_user/ruby_spec.rb . Can you please take a look at those as well and add your output from loginctl to it?

[dix2]

I think that current tests are enough, because change concerns only used ruby code style, written code with just .to_h instead of calling map.to_h depends on the Ruby version (source : stylemaptohash)

[bastelfreak]

Which Ruby version did you use? We support 3.2 and newer.

[dix2]

I would like to support 2.5.0 as minimal...

[bastelfreak]

This is going to be a problem. Ruby 2.5 is Puppet 6. The successor was released 5 years ago. We have no option to validate that the code stays compatible with Ruby 2.5. Can't you upgrade the agent to Puppet 7?

[dix2]

Unfortunately no, nevertheless thank you for these replies

[bastelfreak]

Which issues do you have with the upgrade? Can we assist in some way? You can also come to our IRC/Slack channel to discuss different options: https://voxpupuli.org/connect/ .

[dix2]

I got it, so you can cancel this PR. Thanks a lot, I will remember this proposal