Skip to content

Comments

fix: Correct incorrect characters#43

Merged
vpetrigo merged 1 commit intovpetrigo:masterfrom
geoyee:develop
Jan 15, 2026
Merged

fix: Correct incorrect characters#43
vpetrigo merged 1 commit intovpetrigo:masterfrom
geoyee:develop

Conversation

@geoyee
Copy link
Contributor

@geoyee geoyee commented Jan 14, 2026

This string will trigger a C4819 (code page 936) warning, and since the project is configured to treat warnings as errors, the compilation will fail.

@vpetrigo
Copy link
Owner

@geoyee thank you for the PR.

Would you please share a build log or something with that error specified?

@geoyee
Copy link
Contributor Author

geoyee commented Jan 15, 2026

@geoyee thank you for the PR.

Would you please share a build log or something with that error specified?

Alright, but in Chinese. Here's the terminal output:

[proc] 执行命令: D:\cmake\bin\cmake.EXE --build e:/code/caches/build --config Debug --target ALL_BUILD -j 14 --
[build] 用于 .NET Framework 的 Microsoft (R) 生成引擎版本 16.11.2+f32259642
[build] 版权所有(C) Microsoft Corporation。保留所有权利。
[build] 
[build]   gtest.vcxproj -> E:\code\caches\build\lib\Debug\gtest.lib
[build]   gmock.vcxproj -> E:\code\caches\build\lib\Debug\gmock.lib
[build]   gmock_main.vcxproj -> E:\code\caches\build\lib\Debug\gmock_main.lib
[build]   gtest_main.vcxproj -> E:\code\caches\build\lib\Debug\gtest_main.lib
[build]   nopolicy_cache_tests.cpp
[build]   fifo_cache_tests.cpp
[build]   lru_cache_tests.cpp
[build]   lfu_cache_tests.cpp
[build] E:\code\caches\include\caches/lfu_cache_policy.hpp(1,1): error C2220: 以下警告被视为错误 [E:\code\caches\build\test\lfu_cache_tests.vcxproj]
[build] E:\code\caches\include\caches/lfu_cache_policy.hpp(1,1): warning C4819: 该文件包含不能在当前代码页(936)中表示的字符。请将该文件保存为 Unicode 格式以防止数据丢失 [E:\code\caches\build\test\lfu_cache_tests.vcxproj]
[build]   nopolicy_cache_tests.vcxproj -> E:\code\caches\build\test\Debug\nopolicy_cache_tests.exe
[build]   fifo_cache_tests.vcxproj -> E:\code\caches\build\test\Debug\fifo_cache_tests.exe
[build]   lru_cache_tests.vcxproj -> E:\code\caches\build\test\Debug\lru_cache_tests.exe
[proc] 命令“D:\cmake\bin\cmake.EXE --build e:/code/caches/build --config Debug --target ALL_BUILD -j 14 --”已退出,代码为 1
[driver] 生成完毕: 00:00:08.079
[build] 生成已完成,退出代码为 1

Below is the output of the problem:

[{
	"resource": "/E:/code/caches/include/caches/lfu_cache_policy.hpp",
	"owner": "cmake-build-diags",
	"code": "C2220",
	"severity": 8,
	"message": "以下警告被视为错误 [E:\\code\\caches\\build\\test\\lfu_cache_tests.vcxproj]",
	"source": "MSVC",
	"startLineNumber": 1,
	"startColumn": 1,
	"endLineNumber": 1,
	"endColumn": 1
},{
	"resource": "/E:/code/caches/include/caches/lfu_cache_policy.hpp",
	"owner": "cmake-build-diags",
	"code": "C4819",
	"severity": 4,
	"message": "该文件包含不能在当前代码页(936)中表示的字符。请将该文件保存为 Unicode 格式以防止数据丢失 [E:\\code\\caches\\build\\test\\lfu_cache_tests.vcxproj]",
	"source": "MSVC",
	"startLineNumber": 1,
	"startColumn": 1,
	"endLineNumber": 1,
	"endColumn": 1
}]

@geoyee
Copy link
Contributor Author

geoyee commented Jan 15, 2026

This should be an issue with the Chinese operating system. The default code page for the Chinese version of Windows is GBK (936).

@vpetrigo vpetrigo merged commit b15312f into vpetrigo:master Jan 15, 2026
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants