feat(runtime-vapor): support setup fn and render fn co-usage for expose by zhiyuanzmj · Pull Request #14179 · vuejs/core

zhiyuanzmj · 2025-12-08T08:27:43Z

const Comp = defineVaporComponent({
  setup() {
    // expose
    return {
      foo: 1
    }
  },
  render() {
    return <div />
  }
})

const comp = new Comp()
comp.exposeProxy.foo === 1

coderabbitai · 2025-12-08T08:27:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-08T08:28:47Z

Size Report

Bundles

File	Size	Gzip	Brotli
compiler-dom.global.prod.js	85.5 kB	30 kB	26.4 kB
runtime-dom.global.prod.js	108 kB	40.7 kB	36.6 kB
vue.global.prod.js	167 kB	60.8 kB	54.1 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	48.3 kB	18.9 kB	17.3 kB
createApp	57.3 kB	22 kB	20.1 kB
createApp + vaporInteropPlugin	78.7 kB (+129 B)	29.1 kB (+49 B)	26.5 kB (+56 B)
createVaporApp	28.4 kB (+414 B)	10.9 kB (+157 B)	9.99 kB (+165 B)
createSSRApp	61.6 kB	23.9 kB	21.7 kB
defineCustomElement	63.3 kB	23.9 kB	21.8 kB
overall	72.1 kB	27.3 kB	24.9 kB

pkg-pr-new · 2025-12-08T08:28:55Z

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14179

npm i https://pkg.pr.new/@vue/compiler-core@14179

yarn add https://pkg.pr.new/@vue/compiler-core@14179.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14179

npm i https://pkg.pr.new/@vue/compiler-dom@14179

yarn add https://pkg.pr.new/@vue/compiler-dom@14179.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14179

npm i https://pkg.pr.new/@vue/compiler-sfc@14179

yarn add https://pkg.pr.new/@vue/compiler-sfc@14179.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14179

npm i https://pkg.pr.new/@vue/compiler-ssr@14179

yarn add https://pkg.pr.new/@vue/compiler-ssr@14179.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14179

npm i https://pkg.pr.new/@vue/compiler-vapor@14179

yarn add https://pkg.pr.new/@vue/compiler-vapor@14179.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14179

npm i https://pkg.pr.new/@vue/reactivity@14179

yarn add https://pkg.pr.new/@vue/reactivity@14179.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14179

npm i https://pkg.pr.new/@vue/runtime-core@14179

yarn add https://pkg.pr.new/@vue/runtime-core@14179.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14179

npm i https://pkg.pr.new/@vue/runtime-dom@14179

yarn add https://pkg.pr.new/@vue/runtime-dom@14179.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14179

npm i https://pkg.pr.new/@vue/runtime-vapor@14179

yarn add https://pkg.pr.new/@vue/runtime-vapor@14179.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14179

npm i https://pkg.pr.new/@vue/server-renderer@14179

yarn add https://pkg.pr.new/@vue/server-renderer@14179.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14179

npm i https://pkg.pr.new/@vue/shared@14179

yarn add https://pkg.pr.new/@vue/shared@14179.tgz

vue

pnpm add https://pkg.pr.new/vue@14179

npm i https://pkg.pr.new/vue@14179

yarn add https://pkg.pr.new/vue@14179.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14179

npm i https://pkg.pr.new/@vue/compat@14179

yarn add https://pkg.pr.new/@vue/compat@14179.tgz

commit: 30b21c6

Copilot

Pull request overview

This PR enables defineVaporComponent to support concurrent use of both setup and render functions, allowing components to return state from setup that can be consumed by a render function. Previously, the setup function parameter was explicitly checked, but the new implementation uses a more flexible condition based on whether the setup result is a block.

Key changes:

Removed the setupFn parameter from handleSetupResult function
Modified the production code path to handle setup functions that return non-block state alongside render functions
Updated conditional logic from checking !setupFn to checking !isBlock(setupResult) for determining when to call the render function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/runtime-vapor/src/component.ts

Copilot · 2025-12-08T08:31:51Z

packages/runtime-vapor/src/component.ts

-        ErrorCodes.RENDER_FUNCTION,
-      )
+    // support setup fn and render fn co-usage for defineComponent expose
+    if (!isBlock(setupResult) && component.render) {


Missing devtoolsRawSetupState assignment for production devtools support.

The dev-only path at lines 965-966 sets instance.devtoolsRawSetupState when __DEV__ || __FEATURE_PROD_DEVTOOLS__ is true. This production code path should have the same assignment to ensure devtools work correctly in production builds with devtools enabled.

Suggestion: Add before line 979:

if (__DEV__ || __FEATURE_PROD_DEVTOOLS__) { instance.devtoolsRawSetupState = setupResult }

Suggested change

if (!isBlock(setupResult) && component.render) {

if (!isBlock(setupResult) && component.render) {

if (__DEV__ || __FEATURE_PROD_DEVTOOLS__) {

instance.devtoolsRawSetupState = setupResult

}

Copilot · 2025-12-08T08:31:51Z

packages/runtime-vapor/src/component.ts

+    if (!isBlock(setupResult) && component.render) {
+      instance.setupState = setupResult
+      instance.block =
+        callWithErrorHandling(
+          component.render,
+          instance,
+          ErrorCodes.RENDER_FUNCTION,
+          [
+            instance.setupState,
+            instance.props,
+            instance.emit,
+            instance.attrs,
+            instance.slots,
+          ],
+        ) || []


Missing test coverage for the new setup + render co-usage functionality in production mode.

While there's an existing test at line 420 in component.spec.ts that tests setup + render together, it only verifies dev warnings for non-existent property access. The new production code path (lines 978-992) lacks test coverage for:

Verifying that setupState properties (especially refs) are properly accessible and unwrapped in the render function in production mode

Testing that the render function receives the correct parameters in the expected order

Ensuring devtools integration works correctly with devtoolsRawSetupState

Consider adding a test that:

Sets __DEV__ = false

Creates a component with both setup (returning refs/reactive state) and render functions

Verifies the render function can access and use the setup state correctly

packages/runtime-vapor/src/component.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

netlify · 2026-01-21T05:13:29Z

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name	Link
🔨 Latest commit	`b96b8cf`
🔍 Latest deploy log	https://app.netlify.com/projects/vue-sfc-playground/deploys/697060750c88c30008c525e8

feat(runtime-vapor): support setup fn and render fn co-usage

1385e4a

Copilot AI review requested due to automatic review settings December 8, 2025 08:27

Copilot started reviewing on behalf of zhiyuanzmj December 8, 2025 08:28 View session

Copilot AI reviewed Dec 8, 2025

View reviewed changes

zhiyuanzmj and others added 2 commits December 8, 2025 16:33

Update packages/runtime-vapor/src/component.ts

5929f33

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update packages/runtime-vapor/src/component.ts

f8be210

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

edison1105 added version: minor scope: vapor related to vapor mode labels Dec 8, 2025

zhiyuanzmj added 2 commits December 8, 2025 21:42

chore: Merge branch 'minor' into setup-render

3e6130e

Merge branch 'minor' into setup-render

b96b8cf

zhiyuanzmj force-pushed the setup-render branch from 7a85f92 to b96b8cf Compare January 21, 2026 05:13

feat: setup return as exposed

30b21c6

zhiyuanzmj changed the title ~~feat(runtime-vapor): support setup fn and render fn co-usage for defineVaporComponent~~ feat(runtime-vapor): support setup fn and render fn co-usage for expose Jan 21, 2026

zhiyuanzmj mentioned this pull request Feb 2, 2026

defineVaporComponent types vuejs/vue-jsx-vapor#45

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(runtime-vapor): support setup fn and render fn co-usage for expose#14179

feat(runtime-vapor): support setup fn and render fn co-usage for expose#14179
zhiyuanzmj wants to merge 6 commits intovuejs:minorfrom
zhiyuanzmj:setup-render

zhiyuanzmj commented Dec 8, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 8, 2025 •

edited

Loading

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Dec 8, 2025

Uh oh!

Copilot AI Dec 8, 2025

Uh oh!

Uh oh!

netlify bot commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

zhiyuanzmj commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

netlify bot commented Jan 21, 2026

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zhiyuanzmj commented Dec 8, 2025 •

edited

Loading

coderabbitai bot commented Dec 8, 2025 •

edited

Loading

github-actions bot commented Dec 8, 2025 •

edited

Loading

pkg-pr-new bot commented Dec 8, 2025 •

edited

Loading