-
Notifications
You must be signed in to change notification settings - Fork 5k
docs: correct TypeScript interface for typing global custom directives(via GlobalDirectives)
#3325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tion Co-authored-by: aiktb <104723527+aiktb@users.noreply.github.com>
Co-authored-by: aiktb <104723527+aiktb@users.noreply.github.com>
Fix: Use GlobalDirectives interface for typing global custom directives
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects the TypeScript documentation for typing global custom directives in Vue applications. The fix addresses an incorrect reference to ComponentCustomProperties, replacing it with the correct GlobalDirectives interface.
- Updates the TypeScript interface reference from
ComponentCustomPropertiestoGlobalDirectivesfor typing global custom directives - Ensures consistency between the documentation text and code examples
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GlobalDirectives)GlobalDirectives)
|
Also:
|
Done |
I tested this on the latest versions of Vue (3.5.24) and vue-tsc (3.1.4). ComponentCustomProperties does not work for registering global directives. Instead, you should use GlobalDirectives.