Open
Conversation
✅ Deploy Preview for vue-router-docs-v3 canceled.
|
Author
Which files exactly? im kinda new to this so just the files that need to be covered would be great |
Member
|
You can add it here: https://github.com/vuejs/vue-router/tree/dev/types/test |
Author
Thank you! Will have a look |
Author
is my latest commit what you were looking for in the test? |
Member
|
Thanks! That should be the test. I will take a look on my next pass over vue router 3. |
|
I have updated the code after reading all the comments can you please check this @posva |
Member
|
This is the old non maintained version of Vue router. I only do paid reviews and release for companies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3566
updated typedef of interface Route from
query: Dictionary<string | (string | null)[]>toquery: Dictionary<string | null | (string | null)[]>