Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens GitHub Actions workflow permissions following the principle of least privilege and updates documentation with spelling corrections and usage examples.
Changes:
- Fixed release configuration mapping (changed commit type from 'test' to 'fix' for Bug Fixes category)
- Corrected spelling errors throughout documentation ("Continious" → "Continuous", "privious" → "previous")
- Added explicit permission blocks to workflows and refined existing permissions to grant only necessary access
- Enhanced README with usage examples and improved artifact upload exclusions
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| release.config.js | Fixed commit type mapping from 'test' to 'fix' for Bug Fixes category |
| README.md | Corrected spelling errors and added usage documentation with examples |
| .github/workflows/release.yml | Removed unnecessary permissions (actions, id-token) and added issues permission |
| .github/workflows/precommit.yml | Removed unnecessary pull-requests read permission |
| .github/workflows/ci-init.yml | Fixed spelling in description and added .git/.github exclusions to artifact |
| .github/workflows/ci-autoupdate-github-action.yml | Removed unnecessary pull-requests write permission |
| .github/workflows/aws-tofu-plan-apply.yml | Added explicit permissions block (contents: read, pull-requests: write) |
| .github/workflows/aws-terraform-plan-apply.yml | Added explicit permissions block (contents: read, pull-requests: write) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.md
Outdated
Comment on lines
31
to
36
| init: | ||
| uses: vveliev/ci/.github/workflows/ci-init.yml@main | ||
| with: | ||
| artifact_name: source-code | ||
| artifact_upload: true | ||
| runs-on: "['ubuntu-latest']" |
There was a problem hiding this comment.
The YAML example uses tab characters for indentation, which is invalid in YAML. YAML requires spaces for indentation. The indentation should use spaces instead of tabs.
Suggested change
| init: | |
| uses: vveliev/ci/.github/workflows/ci-init.yml@main | |
| with: | |
| artifact_name: source-code | |
| artifact_upload: true | |
| runs-on: "['ubuntu-latest']" | |
| init: | |
| uses: vveliev/ci/.github/workflows/ci-init.yml@main | |
| with: | |
| artifact_name: source-code | |
| artifact_upload: true | |
| runs-on: "['ubuntu-latest']" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing