remove new line at the start of php files#189
Open
OwlHowl3 wants to merge 2 commits intovyuldashev:masterfrom
Open
remove new line at the start of php files#189OwlHowl3 wants to merge 2 commits intovyuldashev:masterfrom
OwlHowl3 wants to merge 2 commits intovyuldashev:masterfrom
Conversation
|
@vyuldashev - any chance you can merge this in? The json parser on the latest version of Nova complains about the leading new line, so API calls fail. |
|
I just had this breaking laravel/nova 4, because all Inertia request would fail, as it would not send the 'X-Inertia: true' Header anymore after this line had been send. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an extra new line that was breaking API.