-
Notifications
You must be signed in to change notification settings - Fork 18
Add can-lock-orientation CSS media feature #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Changes from all commits
799be6d
b76a334
82353cc
b4e9430
3208037
45b5ee3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -47,11 +47,14 @@ | |||||||||||
| specification, exposes the current type and angle of the device's | ||||||||||||
| screen orientation, and dispatches events when it changes. This enables | ||||||||||||
| web applications to programmatically adapt the user experience for | ||||||||||||
| multiple screen orientations, working alongside CSS. This API is | ||||||||||||
| particularly useful for applications such as computer games, where | ||||||||||||
| users physically rotate the device, but the screen orientation itself | ||||||||||||
| should not change. The API restricts locking the screen orientation | ||||||||||||
| only if certain [=pre-lock conditions=] are met. | ||||||||||||
| multiple screen orientations, working alongside CSS. | ||||||||||||
| The API restricts locking the screen orientation | ||||||||||||
| only if certain [=pre-lock conditions=] are met. | ||||||||||||
| This API particularly useful for applications such as | ||||||||||||
| computer games, where users physically rotate the device, but the | ||||||||||||
| screen orientation itself should not change. The specification also | ||||||||||||
| defines CSS media features to enable feature detection of orientation | ||||||||||||
|
||||||||||||
| defines CSS media features to enable feature detection of orientation | |
| defines a CSS media feature to enable feature detection of orientation |
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] These lines appear redundant with the initial description at lines 917-921. The description "The can-lock-orientation media feature can be used to test whether the user agent supports screen orientation locking functionality" repeats the same information as "used to query whether the user agent supports locking the screen orientation in the current context." Consider removing this paragraph to avoid redundancy.
| <p> | |
| The <a>can-lock-orientation</a> media feature can be used to test | |
| whether the user agent supports screen orientation locking | |
| functionality. | |
| </p> |
Copilot
AI
Nov 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition "The document is not [=Document/fully active=]" is less specific than the actual check performed by the API. According to the common safety checks (line 487-490), the API checks if the document is a "fully active descendant of a top-level traversable with user attention", not just "fully active". Consider updating this to match the actual API requirement to ensure consistency and accuracy.
| <li>The document is not [=Document/fully active=] | |
| <li>The document is not a [=Document/fully active=] descendant of a top-level traversable with user attention |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing word "is" before "particularly useful". Should be "This API is particularly useful for applications..."