-
Notifications
You must be signed in to change notification settings - Fork 258
Deprecate Authenticator Attachment in favor of Hints #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Tim Cappalli <tim@cloudauth.dev>
Co-authored-by: Tim Cappalli <tim@cloudauth.dev>
| <div dfn-type="dict-member" dfn-for="AuthenticatorSelectionCriteria"> | ||
| : <dfn>authenticatorAttachment</dfn> | ||
| :: If this member is present, eligible [=authenticators=] are filtered to be only those authenticators attached with the specified | ||
| :: Note: This member is deprecated in favor of {{PublicKeyCredentialCreationOptions/hints}}. [=[RPS]=] SHOULD use {{PublicKeyCredentialHint/client-device}} instead of {{AuthenticatorAttachment/platform}}, and {{PublicKeyCredentialHint/security-key}} and/or {{PublicKeyCredentialHint/hybrid}} instead of {{AuthenticatorAttachment/cross-platform}} for [=registration ceremony|registration=]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hints support ordering by preference, a nuance that's not currently captured in this value-mapping guidance. I'd rather the nuance be thoroughly explained in the section on User-agent Hints Enumeration, but perhaps here we can simply mention it:
| :: Note: This member is deprecated in favor of {{PublicKeyCredentialCreationOptions/hints}}. [=[RPS]=] SHOULD use {{PublicKeyCredentialHint/client-device}} instead of {{AuthenticatorAttachment/platform}}, and {{PublicKeyCredentialHint/security-key}} and/or {{PublicKeyCredentialHint/hybrid}} instead of {{AuthenticatorAttachment/cross-platform}} for [=registration ceremony|registration=]. | |
| :: Note: This member is deprecated in favor of {{PublicKeyCredentialCreationOptions/hints}}. [=[RPS]=] SHOULD use {{PublicKeyCredentialHint/client-device}} instead of {{AuthenticatorAttachment/platform}}, and {{PublicKeyCredentialHint/security-key}} and/or {{PublicKeyCredentialHint/hybrid}} (ordered by decreasing preference) instead of {{AuthenticatorAttachment/cross-platform}} for [=registration ceremony|registration=]. |
|
|
||
| ### Authenticator Attachment Enumeration (enum <dfn enum>AuthenticatorAttachment</dfn>) ### {#enum-attachment} | ||
|
|
||
| Note: Authenticator Attachment is being deprecated in favor of {{PublicKeyCredentialHint}}. The {{AuthenticatorAttachment/platform}} value is superseded by {{PublicKeyCredentialHint/client-device}}, and {{AuthenticatorAttachment/cross-platform}} is superseded by {{PublicKeyCredentialHint/security-key}} and {{PublicKeyCredentialHint/hybrid}}. [=[RPS]=] SHOULD use {{PublicKeyCredentialCreationOptions/hints}} instead of {{AuthenticatorSelectionCriteria/authenticatorAttachment}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a similar note here: without mentioning the ability to order hints by preference, it'll look to RPs like they must specify cross-platform hints as ["security-key", "hybrid"] when it's totally valid to specify them as ["hybrid", "security-key"] if an RP's preferences deemed it more appropriate.
Closes #2053
The following tasks have been completed:
Implementation commitment:
Documentation and checks