Added complex early stopping based on schedule function#138
Open
Kaisle wants to merge 2 commits intowagenaartje:masterfrom
Open
Added complex early stopping based on schedule function#138Kaisle wants to merge 2 commits intowagenaartje:masterfrom
Kaisle wants to merge 2 commits intowagenaartje:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for an awesome implementation.
I was missing the option to halt training based on a custom condition so I implemented a way to do this using the schedule function.
If the schedule function returns false, training will stop.
This allows you to do a complex early stopping where you stop training if the error rates goes up by a certain amount or doesn't improve beyond a certain amount. It's also minimally invasive to the existing project.
I have updated the documentation to reflect the change.
I hope you will consider it.