chore(weave): Remove trailing slashes on base urls before submitting custom providers to litellm #6063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=4df66093d38984381177211ba18953268f27bf81 |
mscavezze-cw
reviewed
Feb 5, 2026
| extra_headers: dict[str, str] | None = None, | ||
| return_type: str | None = None, | ||
| ) -> tsi.CompletionsCreateRes: | ||
| # Normalize base_url to prevent issues with trailing slashes causing redirects |
Contributor
There was a problem hiding this comment.
The fact that this fixes the issue makes me wonder if we have brittle url-creation code elsewhere. Is that other code something that we can change? If so, a more durable and holistic fix would be to make the other code more resilient to trailing slashes.
Contributor
Author
There was a problem hiding this comment.
@mscavezze-cw Yes unfortunately I believe this issue is on the litellm side of the url construction, we just send them the base url inputted by the user here.
mscavezze-cw
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes trailing slashes from base-urls of custom providers
was causing issues like
wandb.ai//modelwhen sending to litellmTesting
adds some unit tests