refactor: allow embedding wadm#548
Merged
brooksmtownsend merged 9 commits intowasmCloud:mainfrom Jan 17, 2025
Merged
Conversation
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
refactor/for-embedding-wadm
branch
from
9996d95 to
58e60a7
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
refactor/for-embedding-wadm
branch
from
58e60a7 to
472dd32
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
refactor/for-embedding-wadm
branch
from
f2f3235 to
7507a8d
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
refactor/for-embedding-wadm
branch
from
7507a8d to
7e81163
Compare
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
brooksmtownsend
force-pushed
the
refactor/for-embedding-wadm
branch
from
3b97de7 to
228873b
Compare
thomastaylor312
requested changes
Jan 17, 2025
Contributor
thomastaylor312
left a comment
thomastaylor312
left a comment
There was a problem hiding this comment.
Mostly nits but one minor concern around public functions in one of the moved files
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
thomastaylor312
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR reorganizes most of the code from
src/main.rsto be under thewadmcrate instead so that Rust developers can embed wadm into their own library. This is primarily useful with thestart_wadmfunction, which can be called with aWadmConfigstruct with all wadm configuration options. If using in a CLI, theclifeature should be enabled in thewadmcrate to enable the clap attributes to work.Related Issues
Required for wasmCloud/wasmCloud#1061
Release Information
wadm-cli 0.20.0
wadm 0.20.0
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification