Conversation
Contributor
Author
|
@nstauff ready for review |
nstauff
requested changes
Apr 22, 2025
Contributor
nstauff
left a comment
There was a problem hiding this comment.
Thanks @JiaZhou-PU - main comment is to improve the test leveraging more advanced Jinja templating technique that can take list or dictionary. That will make your test/tutorial model much cleaner.
Contributor
Author
|
Updated the templating in the example and tests using the Jinja template. @nstauff |
nstauff
approved these changes
Apr 24, 2025
Contributor
|
@paulromano - this is ready for your review. |
paulromano
requested changes
Apr 27, 2025
Contributor
paulromano
left a comment
There was a problem hiding this comment.
Thanks @JiaZhou-PU and good to see the A-LEAF plugin finally materialize. A few comments for you below:
Contributor
Author
|
@paulromano comments addressed; ready for review. |
paulromano
approved these changes
May 5, 2025
Contributor
paulromano
left a comment
There was a problem hiding this comment.
All looks good now; thanks @JiaZhou-PU!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add A-LEAF plugin and include one example of A-LEAF in example folder
The plugin supports automated modification and execution of ALEAF Fuel prices via parameterized input templates and dynamically modifies
ALEAF_Master_LC_GTEP.xlsxbased on WATTS parameters.Since A-LEAF is still under active development, future support is planned to modify ALEAF inputs in the prerun step based on ALEAF updates.
Checklist: