feat!: parallel execution improvements and foreach removal#3
Merged
Conversation
Users should use regular steps with Elixir's built-in enumeration tools (Enum.map, Task.async_stream) for batch processing instead. - Remove foreach macro from DSL - Remove foreach execution from executor and step runner - Remove foreach-related context functions (current_item, current_index) - Delete foreach test file and guide - Update integration tests to use Enum.map instead of foreach - Update README batch processing example
- Update parallel guide with tagged tuple results model - Add parallel_results/0, parallel_result/1, parallel_ok?/1 helpers docs - Document into: option for custom result transformation - Update all guides with consistent examples - Update parallel tests for results-based model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
foreachprimitive (users should useEnum.map/Task.async_streaminstead)Parallel Execution Changes
New Results Model
Parallel steps now produce results stored in
__results__as tagged tuples:New Helper Functions
parallel_results/0- Get all results mapparallel_result/1- Get specific step resultparallel_ok?/1- Check if step succeededCustom Result Transformation with
into:ForEach Removal (Breaking Change)
The
foreachprimitive is removed. Replace with:Files Changed
lib/durable/dsl/step.ex- Remove foreach macrolib/durable/executor.ex- Remove foreach execution, update parallellib/durable/executor/step_runner.ex- Remove foreach handlinglib/durable/context.ex- Add parallel helpers, remove foreach helpersguides/parallel.md- Document new results modelTest plan
mix precommitpasses