Skip to content

fix: replace delegate_noop with a dispatch that responds to XDG ping #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Decodetalkers merged 1 commit into from
Feb 7, 2026
Merged

fix: replace delegate_noop with a dispatch that responds to XDG ping #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions layershellev/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ use wayland_protocols::xdg::shell::client::{
xdg_positioner::XdgPositioner,
xdg_surface::{self, XdgSurface},
xdg_toplevel::{self, XdgToplevel},
xdg_wm_base::XdgWmBase,
xdg_wm_base::{self, XdgWmBase},
};

use wayland_protocols::{
Expand Down Expand Up @@ -2443,7 +2443,24 @@ delegate_noop!(@<T> WindowState<T>: ignore ZwpVirtualKeyboardManagerV1);
delegate_noop!(@<T> WindowState<T>: ignore ZxdgOutputManagerV1);
delegate_noop!(@<T> WindowState<T>: ignore WpFractionalScaleManagerV1);
delegate_noop!(@<T> WindowState<T>: ignore XdgPositioner);
delegate_noop!(@<T> WindowState<T>: ignore XdgWmBase);

// we need to reply to the ping event otherwise
// top-level windows will be marked as unresponsive
// by the compositor.
impl<T: 'static> Dispatch<XdgWmBase, ()> for WindowState<T> {
fn event(
_state: &mut Self,
proxy: &XdgWmBase,
event: xdg_wm_base::Event,
_data: &(),
_conn: &Connection,
_qh: &QueueHandle<Self>,
) {
if let xdg_wm_base::Event::Ping { serial } = event {
proxy.pong(serial);
}
}
}

delegate_noop!(@<T> WindowState<T>: ignore ZwpTextInputManagerV3);
delegate_noop!(@<T> WindowState<T>: ignore ZwpInputPanelSurfaceV1);
Expand Down