This repository was archived by the owner on Dec 7, 2023. It is now read-only.
add wait check for task.Kill(cc.ctx, syscall.SIGQUIT)#931
Open
Giles2000 wants to merge 1 commit intoweaveworks:mainfrom
Open
add wait check for task.Kill(cc.ctx, syscall.SIGQUIT)#931Giles2000 wants to merge 1 commit intoweaveworks:mainfrom
Giles2000 wants to merge 1 commit intoweaveworks:mainfrom
Conversation
Giles2000
requested review from
chanwit,
darkowlzz and
stealthybox
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when stop the container timeout,ignite will kill the container's task by syscall and delete the killed task.
In practice,kill task will takes a little time to finish (maybe a few hundred milliseconds),
but delete func does not wait for the kill task to complete. It immediately starts checking that the container's task is not running and tries to delete it.
but now,before kill task has completed , the container's task is still running. Therefore, the delete function cannot successfully delete the container.even after a few hundred milliseconds, the container has stopped