Skip to content

feat: keep unknown import.meta properties#12796

Open
intellild wants to merge 1 commit intoweb-infra-dev:mainfrom
intellild:import_meta_preseve_unknown
Open

feat: keep unknown import.meta properties#12796
intellild wants to merge 1 commit intoweb-infra-dev:mainfrom
intellild:import_meta_preseve_unknown

Conversation

@intellild
Copy link
Contributor

@intellild intellild commented Jan 20, 2026

Summary

Unknown import.meta properties are now determined at runtime instead of being statically analyzed at compile time.

Related links

webpack/webpack#20312

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jan 20, 2026

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 435bd3e
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6970da1c68b4050008db202e

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jan 20, 2026
@intellild
Copy link
Contributor Author

Hit compile and a lot of changes in wasi related files. Are these expected ?

@intellild intellild marked this pull request as ready for review January 20, 2026 14:35
@intellild intellild requested a review from hardfist as a code owner January 20, 2026 14:35
@chenjiahan
Copy link
Member

Hit compile and a lot of changes in wasi related files. Are these expected ?

@CPunisher cc

@CPunisher
Copy link
Contributor

This is a bug of napi cli, which sometimes cannot generate exports well. Just revert the rspack.wasi-browser.js and rspack.wasi.cjs

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 12.15%

Comparing intellild:import_meta_preseve_unknown (817bcc8) with main (fbaba99)

Summary

⚡ 1 improved benchmark
✅ 15 untouched benchmarks
⏩ 1 skipped benchmark1

Performance Changes

Benchmark BASE HEAD Efficiency
bundle@threejs-development 823.8 ms 734.6 ms +12.15%

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you update the documentation too?

https://rspack.rs/config/module#moduleparserjavascriptimportmeta

@intellild
Copy link
Contributor Author

I will update the document

@intellild intellild force-pushed the import_meta_preseve_unknown branch 2 times, most recently from ba97b0b to cfbef9d Compare February 1, 2026 14:01
@intellild intellild force-pushed the import_meta_preseve_unknown branch from cfbef9d to 817bcc8 Compare February 1, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants