Conversation
github-actions
bot
added
the
team
hardfist
changed the title
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 5 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 react-10kPath:
📁 react-1kPath:
📁 react-5kPath:
📁 romePath:
📁 ui-componentsPath:
Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🎉 Size decreased by 1.38KB from 48.55MB to 48.55MB (⬇️0.00%) |
|
@codex review |
Merging this PR will not alter performance
Comparing 
Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f285a06463
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Deploying rspack with
|
| Latest commit: |
da45a43
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://01ffdd9d.rspack-v2.pages.dev |
| Branch Preview URL: | https://codex-merge-data-in-compilat.rspack-v2.pages.dev |
hardfist
force-pushed
the
codex/merge-data-in-compilation-and-buildchunkgraphartifact
branch
from
ed9431c to
b8be8be
Compare
|
@claude review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8be8be692
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
hardfist
changed the title
hardfist
requested review from
JSerFeng,
LingyuCoder and
ahabhgk
as code owners
There was a problem hiding this comment.
Pull request overview
This PR refactors the build chunk graph implementation by consolidating chunk graph-related data structures (chunk_by_ukey, chunk_graph, chunk_group_by_ukey, entrypoints, async_entrypoints, named_chunks, named_chunk_groups) from directly on the Compilation struct into a BuildChunkGraphArtifact struct. This change aims to improve code organization and enable better incremental caching by treating the chunk graph as a cohesive artifact that can be recovered and cloned as a unit.
Changes:
- Moved 7 chunk graph-related fields from
CompilationtoBuildChunkGraphArtifact - Updated ~150+ files across the codebase to access these fields via
compilation.build_chunk_graph_artifact.* - Enhanced the memory cache to properly snapshot and recover the
BuildChunkGraphArtifact - Changed
PassExt::after_passsignature from&Compilationto&mut Compilationto support cache operations
Reviewed changes
Copilot reviewed 151 out of 151 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/rspack_core/src/artifacts/build_chunk_graph_artifact.rs |
Restructured artifact to include chunk graph fields directly; added recovery logic |
crates/rspack_core/src/compilation/mod.rs |
Removed 7 chunk graph fields from Compilation struct; updated accessor methods |
crates/rspack_core/src/cache/memory.rs |
Added snapshot mechanism for build_chunk_graph_artifact to support incremental rebuilds |
crates/rspack_core/src/compilation/pass.rs |
Changed after_pass to take mutable compilation reference |
| All other files | Updated field accesses from compilation.X to compilation.build_chunk_graph_artifact.X |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hardfist
deleted the
codex/merge-data-in-compilation-and-buildchunkgraphartifact
branch
2 participants
migrate all related compilation.xxx about chunk_graph into chunk_graph_artifact