WPT: Snapshot internal observers before Subscriber iterates over them#54725
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Sep 5, 2025
Merged
WPT: Snapshot internal observers before Subscriber iterates over them#54725chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
This behavior was already implemented in https://crrev.com/c/6311209, which was a follow-up bug fix to https://crrev.com/c/6221901. It was only recently spec'ed in WICG/observable#214, and this CL adds a WPT for it. This behavior was obliquely tested by: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/dom/observable/tentative/observable-from.any.js;l=675-740;drc=5f8643cf150e97b694f2214ee092c34cc0ccf5fe, as discovered in keithamus/observable-polyfill#38, however this CL adds a simpler, more direct test for this behavior. R=jarhar Bug: 40282760 Change-Id: I43748a09a2f5a235c25ffdbd807e630c187ef2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6915657 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1511774}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6915657
branch
from
484d2c9 to
d780764
Compare
wpt-pr-bot
approved these changes
Sep 5, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior was already implemented in
https://crrev.com/c/6311209, which was a follow-up bug fix to
https://crrev.com/c/6221901. It was only recently spec'ed in
WICG/observable#214, and this CL adds a WPT for
it.
This behavior was obliquely tested by:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/dom/observable/tentative/observable-from.any.js;l=675-740;drc=5f8643cf150e97b694f2214ee092c34cc0ccf5fe,
as discovered in
keithamus/observable-polyfill#38, however this
CL adds a simpler, more direct test for this behavior.
R=jarhar
Bug: 40282760
Change-Id: I43748a09a2f5a235c25ffdbd807e630c187ef2b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6915657
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511774}