[Gecko Bug 2010353] Remove overly restrictive assertion in ColumnSetWrapperFrame::AppendFrames(). #57538
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rames(). We can correctly append elements into a multicol container even when they have column-span descendants, so remove the assertion to allow this operation. The WPT added in this patch triggers the assertion in the old code. Differential Revision: https://phabricator.services.mozilla.com/D281580 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2010353 gecko-commit: ca85711042f0eda5a8db2b2a283688d86211bce5 gecko-reviewers: layout-reviewers, emilio
wpt-pr-bot
approved these changes
Feb 3, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can correctly append elements into a multicol container even when they have
column-span descendants, so remove the assertion to allow this operation.
The WPT added in this patch triggers the assertion in the old code.
Differential Revision: https://phabricator.services.mozilla.com/D281580
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2010353
gecko-commit: ca85711042f0eda5a8db2b2a283688d86211bce5
gecko-reviewers: layout-reviewers, emilio