fix: improve pins vs uploads experience on account page #2117 #1947#2147
Open
alexandrastoica wants to merge 1 commit intomainfrom
Open
fix: improve pins vs uploads experience on account page #2117 #1947#2147alexandrastoica wants to merge 1 commit intomainfrom
alexandrastoica wants to merge 1 commit intomainfrom
Conversation
This was
linked to
issues
Dec 5, 2022
Contributor
This was referenced Dec 5, 2022
adamalton
approved these changes
Dec 6, 2022
Contributor
adamalton
left a comment
There was a problem hiding this comment.
This looks great. I've tested it locally and it meets all the user story requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please also see #1947 for reference.
This PR:
?table=pinned: the previous implementation was not waiting until the pin request was done, hence removing the param and not selecting the table. This PR fixes it by checking if the user has PSA access enabled and setting the tab accordingly.Note: Will handle "I want to be able to see all my pins and their state" from #1947 separately
User stories:
?table=pinnedis cleared up and does not do anything otherwiseUPLOADED VIA PINNING API (0)and the empty table with the messageYou don't have any files pinned yet.?table=pinnedselects the pins table tab unless the user does not have access