Skip to content

Upgrades BUCK build system to the newest version of buckal (Cargo-to-BUCK integration tool) #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genedna merged 2 commits into from
Jan 26, 2026
Merged

Upgrades BUCK build system to the newest version of buckal (Cargo-to-BUCK integration tool) #166

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ab1c3f
Upgrade BUCK with newest buckal
genedna Jan 26, 2026
e92e2a4
Update code fmt
genedna Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ buck-out/
*:Zone.Identifier

.libra//buck-out
/buck-out
253 changes: 1 addition & 252 deletions BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# @generated by `cargo buckal`

load("@buckal//:cargo_manifest.bzl", "cargo_manifest")
load("@buckal//:wrapper.bzl", "rust_binary", "rust_library", "rust_test")
load("@buckal//:wrapper.bzl", "rust_binary", "rust_library")
Comment on lines 3 to +4
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore Buck test targets for buck2 test usage

BUCK now only loads rust_binary/rust_library and there are no rust_test rules in the repo (I confirmed with rg "rust_test" -n .). That means Buck no longer has any test targets for this crate, so any workflow that relies on Buck-based testing (e.g., buck2 test //libra/..., which the repo’s .github/copilot-instructions.md calls out as the canonical CI/integration command) will stop running unit/integration tests altogether. If Buck is still a supported path, consider re-enabling rust_test generation or adding equivalent test rules so Buck test coverage isn’t silently dropped.

Useful? React with 👍 / 👎.


filegroup(
name = "libra-vendor",
Expand Down Expand Up @@ -151,254 +151,3 @@ rust_library(
"//third-party/rust/crates/wax/0.6.0:wax",
],
)

rust_test(
name = "libra-unittest",
srcs = [":libra-vendor"],
crate = "libra",
crate_root = "vendor/src/lib.rs",
edition = "2024",
features = ["default"],
rustc_flags = ["@$(location :libra-manifest[env_flags])"] + select({
"prelude//os/constraints:windows": select({
"prelude//abi/constraints:gnu": [
"@$(location //third-party/rust/crates/windows_x86_64_gnu/0.48.5:windows_x86_64_gnu-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_gnu/0.52.6:windows_x86_64_gnu-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_gnu/0.53.1:windows_x86_64_gnu-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/winapi-x86_64-pc-windows-gnu/0.4.0:winapi-x86_64-pc-windows-gnu-build-script-run[rustc_flags])",
],
"DEFAULT": [
"@$(location //third-party/rust/crates/windows_x86_64_msvc/0.48.5:windows_x86_64_msvc-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_msvc/0.52.6:windows_x86_64_msvc-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_msvc/0.53.1:windows_x86_64_msvc-build-script-run[rustc_flags])",
],
}),
"DEFAULT": [],
}),
os_deps = {
"linux": ["//third-party/rust/crates/pager/0.16.1:pager"],
"macos": ["//third-party/rust/crates/pager/0.16.1:pager"],
},
visibility = ["PUBLIC"],
deps = [
"//third-party/rust/crates/anyhow/1.0.100:anyhow",
"//third-party/rust/crates/async-trait/0.1.89:async-trait",
"//third-party/rust/crates/byte-unit/5.2.0:byte-unit",
"//third-party/rust/crates/byteorder/1.5.0:byteorder",
"//third-party/rust/crates/bytes/1.11.0:bytes",
"//third-party/rust/crates/chrono/0.4.42:chrono",
"//third-party/rust/crates/clap/4.5.53:clap",
"//third-party/rust/crates/colored/3.0.0:colored",
"//third-party/rust/crates/crc32fast/1.5.0:crc32fast",
"//third-party/rust/crates/diffs/0.5.1:diffs",
"//third-party/rust/crates/dirs/5.0.1:dirs",
"//third-party/rust/crates/flate2/1.1.5:flate2",
"//third-party/rust/crates/futures-util/0.3.31:futures-util",
"//third-party/rust/crates/futures/0.3.31:futures",
"//third-party/rust/crates/git-internal/0.4.0:git-internal",
"//third-party/rust/crates/hex/0.4.3:hex",
"//third-party/rust/crates/http/1.4.0:http",
"//third-party/rust/crates/ignore/0.4.25:ignore",
"//third-party/rust/crates/indicatif/0.18.3:indicatif",
"//third-party/rust/crates/infer/0.19.0:infer",
"//third-party/rust/crates/lazy_static/1.5.0:lazy_static",
"//third-party/rust/crates/lru-mem/0.3.0:lru-mem",
"//third-party/rust/crates/object_store/0.12.4:object_store",
"//third-party/rust/crates/once_cell/1.21.3:once_cell",
"//third-party/rust/crates/path-absolutize/3.1.1:path-absolutize",
"//third-party/rust/crates/pathdiff/0.2.3:pathdiff",
"//third-party/rust/crates/regex/1.12.2:regex",
"//third-party/rust/crates/reqwest/0.12.24:reqwest",
"//third-party/rust/crates/ring/0.17.14:ring",
"//third-party/rust/crates/rpassword/7.4.0:rpassword",
"//third-party/rust/crates/scopeguard/1.2.0:scopeguard",
"//third-party/rust/crates/sea-orm/1.1.19:sea-orm",
"//third-party/rust/crates/serde/1.0.228:serde",
"//third-party/rust/crates/serde_json/1.0.145:serde_json",
"//third-party/rust/crates/serial_test/3.2.0:serial_test",
"//third-party/rust/crates/sha1/0.10.6:sha1",
"//third-party/rust/crates/similar/2.7.0:similar",
"//third-party/rust/crates/tempfile/3.24.0:tempfile",
"//third-party/rust/crates/testcontainers/0.25.2:testcontainers",
"//third-party/rust/crates/thiserror/2.0.17:thiserror",
"//third-party/rust/crates/tokio-util/0.7.17:tokio-util",
"//third-party/rust/crates/tokio/1.48.0:tokio",
"//third-party/rust/crates/tracing-subscriber/0.3.22:tracing-subscriber",
"//third-party/rust/crates/tracing/0.1.44:tracing",
"//third-party/rust/crates/url/2.5.7:url",
"//third-party/rust/crates/walkdir/2.5.0:walkdir",
"//third-party/rust/crates/wax/0.6.0:wax",
],

target_compatible_with = select({"//platforms:cross": ["config//:none"], "DEFAULT": []}),
)

rust_test(
name = "command_test",
srcs = [":libra-vendor"],
crate = "command_test",
crate_root = "vendor/tests/command_test.rs",
edition = "2024",
env = {
"CARGO_BIN_EXE_libra": "$(location :libra)",
},
features = ["default"],
rustc_flags = ["@$(location :libra-manifest[env_flags])"] + select({
"prelude//os/constraints:windows": select({
"prelude//abi/constraints:gnu": [
"@$(location //third-party/rust/crates/windows_x86_64_gnu/0.48.5:windows_x86_64_gnu-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_gnu/0.52.6:windows_x86_64_gnu-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_gnu/0.53.1:windows_x86_64_gnu-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/winapi-x86_64-pc-windows-gnu/0.4.0:winapi-x86_64-pc-windows-gnu-build-script-run[rustc_flags])",
],
"DEFAULT": [
"@$(location //third-party/rust/crates/windows_x86_64_msvc/0.48.5:windows_x86_64_msvc-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_msvc/0.52.6:windows_x86_64_msvc-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_msvc/0.53.1:windows_x86_64_msvc-build-script-run[rustc_flags])",
],
}),
"DEFAULT": [],
}),
os_deps = {
"linux": ["//third-party/rust/crates/pager/0.16.1:pager"],
"macos": ["//third-party/rust/crates/pager/0.16.1:pager"],
},
visibility = ["PUBLIC"],
deps = [
"//third-party/rust/crates/anyhow/1.0.100:anyhow",
"//third-party/rust/crates/async-trait/0.1.89:async-trait",
"//third-party/rust/crates/byte-unit/5.2.0:byte-unit",
"//third-party/rust/crates/byteorder/1.5.0:byteorder",
"//third-party/rust/crates/bytes/1.11.0:bytes",
"//third-party/rust/crates/chrono/0.4.42:chrono",
"//third-party/rust/crates/clap/4.5.53:clap",
"//third-party/rust/crates/colored/3.0.0:colored",
"//third-party/rust/crates/crc32fast/1.5.0:crc32fast",
"//third-party/rust/crates/diffs/0.5.1:diffs",
"//third-party/rust/crates/dirs/5.0.1:dirs",
"//third-party/rust/crates/flate2/1.1.5:flate2",
"//third-party/rust/crates/futures-util/0.3.31:futures-util",
"//third-party/rust/crates/futures/0.3.31:futures",
"//third-party/rust/crates/git-internal/0.4.0:git-internal",
"//third-party/rust/crates/hex/0.4.3:hex",
"//third-party/rust/crates/http/1.4.0:http",
"//third-party/rust/crates/ignore/0.4.25:ignore",
"//third-party/rust/crates/indicatif/0.18.3:indicatif",
"//third-party/rust/crates/infer/0.19.0:infer",
"//third-party/rust/crates/lazy_static/1.5.0:lazy_static",
"//third-party/rust/crates/lru-mem/0.3.0:lru-mem",
"//third-party/rust/crates/object_store/0.12.4:object_store",
"//third-party/rust/crates/once_cell/1.21.3:once_cell",
"//third-party/rust/crates/path-absolutize/3.1.1:path-absolutize",
"//third-party/rust/crates/pathdiff/0.2.3:pathdiff",
"//third-party/rust/crates/regex/1.12.2:regex",
"//third-party/rust/crates/reqwest/0.12.24:reqwest",
"//third-party/rust/crates/ring/0.17.14:ring",
"//third-party/rust/crates/rpassword/7.4.0:rpassword",
"//third-party/rust/crates/scopeguard/1.2.0:scopeguard",
"//third-party/rust/crates/sea-orm/1.1.19:sea-orm",
"//third-party/rust/crates/serde/1.0.228:serde",
"//third-party/rust/crates/serde_json/1.0.145:serde_json",
"//third-party/rust/crates/serial_test/3.2.0:serial_test",
"//third-party/rust/crates/sha1/0.10.6:sha1",
"//third-party/rust/crates/similar/2.7.0:similar",
"//third-party/rust/crates/tempfile/3.24.0:tempfile",
"//third-party/rust/crates/testcontainers/0.25.2:testcontainers",
"//third-party/rust/crates/thiserror/2.0.17:thiserror",
"//third-party/rust/crates/tokio-util/0.7.17:tokio-util",
"//third-party/rust/crates/tokio/1.48.0:tokio",
"//third-party/rust/crates/tracing-subscriber/0.3.22:tracing-subscriber",
"//third-party/rust/crates/tracing/0.1.44:tracing",
"//third-party/rust/crates/url/2.5.7:url",
"//third-party/rust/crates/walkdir/2.5.0:walkdir",
"//third-party/rust/crates/wax/0.6.0:wax",
":liblibra",
],

target_compatible_with = select({"//platforms:cross": ["config//:none"], "DEFAULT": []}),
)

rust_test(
name = "storage_r2_test",
srcs = [":libra-vendor"],
crate = "storage_r2_test",
crate_root = "vendor/tests/storage_r2_test.rs",
edition = "2024",
env = {
"CARGO_BIN_EXE_libra": "$(location :libra)",
},
features = ["default"],
rustc_flags = ["@$(location :libra-manifest[env_flags])"] + select({
"prelude//os/constraints:windows": select({
"prelude//abi/constraints:gnu": [
"@$(location //third-party/rust/crates/windows_x86_64_gnu/0.48.5:windows_x86_64_gnu-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_gnu/0.52.6:windows_x86_64_gnu-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_gnu/0.53.1:windows_x86_64_gnu-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/winapi-x86_64-pc-windows-gnu/0.4.0:winapi-x86_64-pc-windows-gnu-build-script-run[rustc_flags])",
],
"DEFAULT": [
"@$(location //third-party/rust/crates/windows_x86_64_msvc/0.48.5:windows_x86_64_msvc-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_msvc/0.52.6:windows_x86_64_msvc-build-script-run[rustc_flags])",
"@$(location //third-party/rust/crates/windows_x86_64_msvc/0.53.1:windows_x86_64_msvc-build-script-run[rustc_flags])",
],
}),
"DEFAULT": [],
}),
os_deps = {
"linux": ["//third-party/rust/crates/pager/0.16.1:pager"],
"macos": ["//third-party/rust/crates/pager/0.16.1:pager"],
},
visibility = ["PUBLIC"],
deps = [
"//third-party/rust/crates/anyhow/1.0.100:anyhow",
"//third-party/rust/crates/async-trait/0.1.89:async-trait",
"//third-party/rust/crates/byte-unit/5.2.0:byte-unit",
"//third-party/rust/crates/byteorder/1.5.0:byteorder",
"//third-party/rust/crates/bytes/1.11.0:bytes",
"//third-party/rust/crates/chrono/0.4.42:chrono",
"//third-party/rust/crates/clap/4.5.53:clap",
"//third-party/rust/crates/colored/3.0.0:colored",
"//third-party/rust/crates/crc32fast/1.5.0:crc32fast",
"//third-party/rust/crates/diffs/0.5.1:diffs",
"//third-party/rust/crates/dirs/5.0.1:dirs",
"//third-party/rust/crates/flate2/1.1.5:flate2",
"//third-party/rust/crates/futures-util/0.3.31:futures-util",
"//third-party/rust/crates/futures/0.3.31:futures",
"//third-party/rust/crates/git-internal/0.4.0:git-internal",
"//third-party/rust/crates/hex/0.4.3:hex",
"//third-party/rust/crates/http/1.4.0:http",
"//third-party/rust/crates/ignore/0.4.25:ignore",
"//third-party/rust/crates/indicatif/0.18.3:indicatif",
"//third-party/rust/crates/infer/0.19.0:infer",
"//third-party/rust/crates/lazy_static/1.5.0:lazy_static",
"//third-party/rust/crates/lru-mem/0.3.0:lru-mem",
"//third-party/rust/crates/object_store/0.12.4:object_store",
"//third-party/rust/crates/once_cell/1.21.3:once_cell",
"//third-party/rust/crates/path-absolutize/3.1.1:path-absolutize",
"//third-party/rust/crates/pathdiff/0.2.3:pathdiff",
"//third-party/rust/crates/regex/1.12.2:regex",
"//third-party/rust/crates/reqwest/0.12.24:reqwest",
"//third-party/rust/crates/ring/0.17.14:ring",
"//third-party/rust/crates/rpassword/7.4.0:rpassword",
"//third-party/rust/crates/scopeguard/1.2.0:scopeguard",
"//third-party/rust/crates/sea-orm/1.1.19:sea-orm",
"//third-party/rust/crates/serde/1.0.228:serde",
"//third-party/rust/crates/serde_json/1.0.145:serde_json",
"//third-party/rust/crates/serial_test/3.2.0:serial_test",
"//third-party/rust/crates/sha1/0.10.6:sha1",
"//third-party/rust/crates/similar/2.7.0:similar",
"//third-party/rust/crates/tempfile/3.24.0:tempfile",
"//third-party/rust/crates/testcontainers/0.25.2:testcontainers",
"//third-party/rust/crates/thiserror/2.0.17:thiserror",
"//third-party/rust/crates/tokio-util/0.7.17:tokio-util",
"//third-party/rust/crates/tokio/1.48.0:tokio",
"//third-party/rust/crates/tracing-subscriber/0.3.22:tracing-subscriber",
"//third-party/rust/crates/tracing/0.1.44:tracing",
"//third-party/rust/crates/url/2.5.7:url",
"//third-party/rust/crates/walkdir/2.5.0:walkdir",
"//third-party/rust/crates/wax/0.6.0:wax",
":liblibra",
],

target_compatible_with = select({"//platforms:cross": ["config//:none"], "DEFAULT": []}),
)
2 changes: 1 addition & 1 deletion buckal.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
version = 2

[fingerprints]
"path+file://($WORKSPACE)#0.1.0" = "64f541ac2c275c19bb9d8ec206ebf7d2c976d7825b7146f8cdb67a137ea03e29"
"path+file://($WORKSPACE)#0.1.0" = "2f3414b17b44b734211ada6967050e3e6def8a0345dfa5c0f529ca9dca47935c"
"registry+https://github.com/rust-lang/crates.io-index#adler2@2.0.1" = "7081ce7693ca45bff0e855374e6b7f386805bba1de9f7c288b1c706b99abef7f"
"registry+https://github.com/rust-lang/crates.io-index#ahash@0.7.8" = "263bbc26dec8ade458658cf9dae3ef8fc606e85f04c7b47abb4f9255319689ac"
"registry+https://github.com/rust-lang/crates.io-index#ahash@0.8.12" = "f778671dc433ee46d961aca6e08860d4146d990e1822df6b553893e379d8bfa5"
Expand Down
1 change: 0 additions & 1 deletion buckal.toml
View file
Open in desktop

This file was deleted.