Update crates version#67
Merged
genedna merged 3 commits intoweb3infra-foundation:mainfrom Nov 25, 2025
Merged
Conversation
Signed-off-by: Quanyi Ma <eli@patch.sh>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates dependency versions in the libra crate, removing many unused dependencies and updating the remaining ones to specific semantic versions. The changes include:
- Dependency cleanup: Removed ~60 unused dependencies (e.g.,
ahash,axum,bincode,dashmap,encoding_rs,openssl,quickcheck,rayon, etc.) - Version updates: Updated all remaining dependencies to fully specified versions (e.g.,
anyhowfrom "1.0" to "1.0.100") - Feature additions: Added
"process"feature totokioin dev-dependencies
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Removed ~60 unused dependencies and updated remaining dependencies to fully specified versions with proper formatting |
| Cargo.lock | Automatically regenerated to reflect the Cargo.toml changes, removing transitive dependencies of removed crates |
Signed-off-by: Quanyi Ma <eli@patch.sh>
| } | ||
|
|
||
| // Fallback 3: root directory to ensure a stable, existing path | ||
| PathBuf::from("/") |
There was a problem hiding this comment.
The fallback path / (root directory) on line 56 is problematic. This would be inappropriate as a working directory on most systems due to permission constraints, and could lead to unexpected behavior. Consider using a more appropriate fallback such as the user's home directory or a temp directory.
Signed-off-by: Quanyi Ma <eli@patch.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.