build: fix buckal cache#73
Merged
genedna merged 1 commit intoweb3infra-foundation:mainfrom Dec 5, 2025
Merged
Conversation
Signed-off-by: jl.jiang <jiangjl9807@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Buckal cache portability by replacing a hardcoded absolute path with a workspace placeholder and adding a configuration file. Buckal is a Cargo plugin used in this repository for Buck2 build system integration and dependency management.
- Adds
buckal.tomlconfiguration file to control Buckal behavior - Replaces hardcoded absolute path with
($WORKSPACE)placeholder inbuckal.snapto make the cache portable across different developer machines
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| buckal.toml | New configuration file that sets ignore_tests = false, ensuring test dependencies are included in Buck2 build generation |
| buckal.snap | Replaces hardcoded absolute path /home/jl-jiang/Dev/r2cn/libra with portable ($WORKSPACE) placeholder, fixing cache portability issues |
genedna
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.