Skip to content

Comments

build: fix platform compatibility#76

Merged
genedna merged 1 commit intoweb3infra-foundation:mainfrom
jjl9807:dev
Dec 7, 2025
Merged

build: fix platform compatibility#76
genedna merged 1 commit intoweb3infra-foundation:mainfrom
jjl9807:dev

Conversation

@jjl9807
Copy link
Collaborator

@jjl9807 jjl9807 commented Dec 7, 2025

fix #75

Signed-off-by: jl.jiang <jiangjl9807@gmail.com>
Copilot AI review requested due to automatic review settings December 7, 2025 08:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes platform compatibility issues by adding Buck2 compatible_with constraints to platform-specific Rust dependencies and removes an unused dependency. The changes prevent build failures when attempting to build on incompatible platforms.

  • Added macOS-only constraint to system-configuration crate
  • Added Windows-only constraint to hyper-named-pipe crate
  • Removed unused internal-russh-forked-ssh-key dependency
  • Updated buckal.snap fingerprint reflecting workspace changes

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
third-party/rust/crates/system-configuration/0.6.1/BUCK Added compatible_with = ["prelude//os:macos"] to constrain build to macOS platform
third-party/rust/crates/hyper-named-pipe/0.1.0/BUCK Added compatible_with = ["prelude//os:windows"] to constrain build to Windows platform
third-party/rust/crates/internal-russh-forked-ssh-key/0.6.11+upstream-0.6.7/BUCK Deleted entire BUCK file for unused dependency
buckal.snap Updated workspace fingerprint hash reflecting the dependency changes
Comments suppressed due to low confidence (1)

third-party/rust/crates/internal-russh-forked-ssh-key/0.6.11+upstream-0.6.7/BUCK:1

  • This BUCK target previously compiled the internal_russh_forked_ssh_key crate with weak cryptographic options such as the rsa-sha1 feature and hazmat-allow-insecure-rsa-keys, which can enable SHA-1 based RSA signatures and insecure RSA key sizes in SSH key handling. An attacker who can influence which algorithms are negotiated or which keys are accepted could exploit these weaker primitives to degrade security compared to modern RSA+SHA2 with sufficiently large keys. Removing this target from the Buck build mitigates the issue here; if this crate is still built elsewhere, ensure it is configured to use only strong algorithms (e.g., RSA with SHA-256/512 and keys ≥2048 bits).

@genedna genedna merged commit d73522e into web3infra-foundation:main Dec 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cargo Buckal Build 出现问题

2 participants