build: fix platform compatibility#76
Merged
genedna merged 1 commit intoweb3infra-foundation:mainfrom Dec 7, 2025
Merged
Conversation
Signed-off-by: jl.jiang <jiangjl9807@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes platform compatibility issues by adding Buck2 compatible_with constraints to platform-specific Rust dependencies and removes an unused dependency. The changes prevent build failures when attempting to build on incompatible platforms.
- Added macOS-only constraint to
system-configurationcrate - Added Windows-only constraint to
hyper-named-pipecrate - Removed unused
internal-russh-forked-ssh-keydependency - Updated
buckal.snapfingerprint reflecting workspace changes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| third-party/rust/crates/system-configuration/0.6.1/BUCK | Added compatible_with = ["prelude//os:macos"] to constrain build to macOS platform |
| third-party/rust/crates/hyper-named-pipe/0.1.0/BUCK | Added compatible_with = ["prelude//os:windows"] to constrain build to Windows platform |
| third-party/rust/crates/internal-russh-forked-ssh-key/0.6.11+upstream-0.6.7/BUCK | Deleted entire BUCK file for unused dependency |
| buckal.snap | Updated workspace fingerprint hash reflecting the dependency changes |
Comments suppressed due to low confidence (1)
third-party/rust/crates/internal-russh-forked-ssh-key/0.6.11+upstream-0.6.7/BUCK:1
- This BUCK target previously compiled the
internal_russh_forked_ssh_keycrate with weak cryptographic options such as thersa-sha1feature andhazmat-allow-insecure-rsa-keys, which can enable SHA-1 based RSA signatures and insecure RSA key sizes in SSH key handling. An attacker who can influence which algorithms are negotiated or which keys are accepted could exploit these weaker primitives to degrade security compared to modern RSA+SHA2 with sufficiently large keys. Removing this target from the Buck build mitigates the issue here; if this crate is still built elsewhere, ensure it is configured to use only strong algorithms (e.g., RSA with SHA-256/512 and keys ≥2048 bits).
genedna
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #75