feat: adding support for WebSocket#714
Draft
JeneaVranceanu wants to merge 36 commits intoweb3swift-team:develop-4.0from
Draft
feat: adding support for WebSocket#714JeneaVranceanu wants to merge 36 commits intoweb3swift-team:develop-4.0from
JeneaVranceanu wants to merge 36 commits intoweb3swift-team:develop-4.0from
Conversation
Collaborator
|
It could be missed in the rush, so I just refresh it: why do we consider adding websocket as 4.0 feature rather then minor update for the 3.* one @JeneaVranceanu? |
Collaborator
Author
@yaroslavyaroslav I think we will have to change the way we store and manage |
Collaborator
|
@JeneaVranceanu I'm really curious why the WebSocket will lead to changes that you've mentioned. Looking forward to hear from you, no rushing tho. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: It's a WIP. If you wish to you can review the PR but it's not finished yet.
Summary of Changes
Adds support for WebSockets that will be part of 4.0 release.
DefaultWeb3SocketClientwas added and is based on the nativeURLSessionWebSocketTask. It's wrapped in#if !os(Linux) ... #endifso we can add a separate instance ofDefaultWeb3SocketClientfor Linux based on some other library that supports Linux.Issues that are left to resolve/add:
attachedKeystoreto theweb3class;Test Data or Screenshots
empty
By submitting this pull request, you are confirming the following:
developbranch.