Open
Conversation
- modified to allow an optional type of 'totalDifficulty' - because 'totalDifficulty' was removed from Ethereum official Blockschema
JeneaVranceanu
requested changes
Oct 31, 2024
Collaborator
There was a problem hiding this comment.
Looks good to me but this is a breaking change and we can only make it part of the v4 which I'm not sure when will be released.
If I make it target the develop-v4.0 branch than we have a problem:
What I suggest is that we keep the totalDifficulty: BigUInt non optional and during decoding we provide a default value set to 0. We will add a comment alongside yours telling that 0 means this value is not defined and shall not be used.
Co-authored-by: Jenea Vranceanu <36865532+JeneaVranceanu@users.noreply.github.com>
Co-authored-by: Jenea Vranceanu <36865532+JeneaVranceanu@users.noreply.github.com>
Author
|
Very Good Idea. |
JeneaVranceanu
previously approved these changes
Nov 5, 2024
yaroslavyaroslav
force-pushed
the
develop
branch
4 times, most recently
from
a0218ff to
8c152f5
Compare
yaroslavyaroslav
force-pushed
the
develop
branch
9 times, most recently
from
a31d891 to
e215270
Compare
Author
|
Is there anything else I need to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified to allow an optional type of 'totalDifficulty'
According to 'ethereum/execution-apis@9e16d5e', you can see that the 'totalDifficulty field was removed from the Blockschema on September 4.
Since the existing structure required a 'totalDifficulty' field, if the result of a json structure without a 'totalDifficulty' field is returned from the Ethereum node, there is an issue that decoding fails in the web3swift library. To solve this problem, the 'totalDifficulty' field was changed to an optional field.
Summary of Changes
modified 'totalDifficulty' to optional type in Block struct
By submitting this pull request, you are confirming the following:
developbranch.