Some improvements in my opinion for kubernetes #40
Some improvements in my opinion for kubernetes #40promzeus wants to merge 5 commits intowebdevops:mainfrom
Conversation
added Process.PID added started_at time in log
|
Some improvements in my opinion for kubernetes |
| _, err := r.cron.AddFunc(cronjob.Spec, r.cmdFunc(cronjob, func(execCmd *exec.Cmd) bool { | ||
| // before exec callback | ||
| log.WithFields(LogCronjobToFields(cronjob)).Infof("executing") | ||
| // log.WithFields(LogCronjobToFields(cronjob)).Infof("executing") |
| } | ||
|
|
||
| log.WithFields(logFields).Info("finished") | ||
| // log.WithFields(logFields).Info("finished") |
|
I think the separate line |
|
If you mix the start and finish separately in the logs. Then we get a lot of garbage messages and we will have to compare by PID where exactly this team started and where exactly it finished, and the debug message to which start it belongs. |
No description provided.