fix: .not should also wait for conditions (Breaking changes of issue 1982)#2014
Merged
christian-bromann merged 8 commits intowebdriverio:mainfrom Feb 1, 2026
Conversation
dprevost-LMI
changed the title
.not should also wait for conditions to be meet while issue https://github.com/webdriverio/expect-webdriverio/pull/1983 is a breaking changes.not should also wait for conditions (Breaking changes of issue 1983)
dprevost-LMI
force-pushed
the
not-should-also-wait-revert-issue-1982
branch
from
ccf5d79 to
bbf1788
Compare
dprevost-LMI
changed the title
.not should also wait for conditions (Breaking changes of issue 1983).not should also wait for conditions (Breaking changes of issue 1982)
sometimes when run too fast, it triggers conditions one more time than expected
11 tasks
dprevost-LMI
commented
Jan 30, 2026
dprevost-LMI
commented
Jan 30, 2026
dprevost-LMI
commented
Jan 30, 2026
Contributor
|
Hey dprevost-LMI 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Contributor
Author
|
@christian-bromann, do you mind triggering a separate release for this and shipping the fix for the regression alone? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2013
While trying to clarify & align the
.notbehaviour so we can move forward with support for$$(), this introduces breaking changes to the current expected behaviour. Reverting the assumed problem to keep the today expected behaviour and revisit it later if needed.So
waitUntil#1983isNotis not always properly considered inwaitUntil#1982.notreying until the reverse condition is met, e.g, until the element is no longer present.notmodifiers' behaviour to clarify its intentions.