Open
Conversation
bbaldino
reviewed
Jun 10, 2024
src/event-mixin.ts
Outdated
| * Remove all event listeners from all events. | ||
| */ | ||
| removeAllListeners() { | ||
| Object.keys(this).forEach((eventName) => { |
Contributor
There was a problem hiding this comment.
So this works correctly with inheritance I guess?
Collaborator
Author
There was a problem hiding this comment.
Good catch. The removeAllListeners method has been updated to ensure it works with inherited events by traversing the prototype chain using a helper function. Unit tests updated as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
removeAllListenersmethod to theAddEventsmixin, allowing for the removal of all event listeners from instances of classes using this mixin. The implementation iterates through allTypedEventmembers and callsremoveAllListenerson each, ensuring a clean state. Unit tests have been included to verify that the method correctly removes all listeners for both parent and child classes.