Skip to content

Comments

fix(meetings): update max bitrate base on resolution#4732

Open
szotrabh wants to merge 1 commit intowebex:nextfrom
szotrabh:update_max_bitrate
Open

fix(meetings): update max bitrate base on resolution#4732
szotrabh wants to merge 1 commit intowebex:nextfrom
szotrabh:update_max_bitrate

Conversation

@szotrabh
Copy link
Contributor

@szotrabh szotrabh commented Feb 20, 2026

COMPLETES #SPARK-746906

This pull request addresses

Update preferred bitrate on local video constraints change
Adds a localConstraintsChangeHandler that listens for ConstraintsChange events on the local video stream in transcoded (non-multistream) meetings. When video constraints change (e.g., resolution), updatePreferredBitrateKbps() is called on the media connection to adjust the preferred bitrate accordingly.

Changes
Defined localConstraintsChangeHandler in the Meeting constructor
Registered the handler on ConstraintsChange in setLocalVideoStream()
Unregistered the handler in setLocalVideoStream() and cleanupLocalStreams()

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@szotrabh szotrabh requested review from a team as code owners February 20, 2026 15:29
@szotrabh szotrabh added the validated If the pull request is validated for automation. label Feb 20, 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source code looks good, can we add tests for the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants