fix(meetings): update max bitrate base on resolution#4732
Open
szotrabh wants to merge 1 commit intowebex:nextfrom
Open
fix(meetings): update max bitrate base on resolution#4732szotrabh wants to merge 1 commit intowebex:nextfrom
szotrabh wants to merge 1 commit intowebex:nextfrom
Conversation
Contributor
There was a problem hiding this comment.
Source code looks good, can we add tests for the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-746906
This pull request addresses
Update preferred bitrate on local video constraints change
Adds a localConstraintsChangeHandler that listens for ConstraintsChange events on the local video stream in transcoded (non-multistream) meetings. When video constraints change (e.g., resolution), updatePreferredBitrateKbps() is called on the media connection to adjust the preferred bitrate accordingly.
Changes
Defined localConstraintsChangeHandler in the Meeting constructor
Registered the handler on ConstraintsChange in setLocalVideoStream()
Unregistered the handler in setLocalVideoStream() and cleanupLocalStreams()
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.