Fix: Process all disallowed elements instead of stopping after first#46
Merged
webworkerJoshua merged 1 commit intowebworkerJoshua:masterfrom Aug 15, 2025
Conversation
- Fix bug in checkElementsWithRequiredConsent() where return statement caused loop to exit after processing first disallowed element - Change return to continue to ensure all blocked elements get consent messages - Resolves issue where only first element with denied consent category would display ask-consent message, subsequent elements were ignored 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Looks good to me. (I suspect the author forgot it was a for () loop not a [].forEach() style loop!) |
webworkerJoshua
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkElementsWithRequiredConsent()where earlyreturncaused loop to exit after processing first disallowed elementreturntocontinueto ensure all blocked elements get consent messagesProblem
When multiple elements on a page require the same denied consent category (e.g., iframe + script both needing
external_media), only the first element displays a consent message. Subsequent elements are silently blocked without any user-facing consent request.Root Cause
Bug in
checkElementsWithRequiredConsent()method (line 435)Solution
Test Results ✅
Related Issue
Fixes #45
🤖 Generated with Claude Code