Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* move the import of distutils to where it is required * also catches ModuleNotFoundErrors occuring from 3.12 onwards Signed-off-by: Adrian Braemer <bradrian@gmail.com>
Contributor
|
Bummer plugins where integrated that way. Entrypoints in setuptools are a slightly nicer way to accomplish that. https://setuptools.pypa.io/en/latest/userguide/entry_point.html#entry-points-for-plugins |
Collaborator
|
I think this has been solved by adab259, let's make sure that the plugins still work though. And if not, we can fix that before the release. |
Collaborator
|
I think this should work in latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #611 states,
distutilshas been removed from Python 3.12 onwards. This means that the current release of whipper does not run on Ubuntu 24.04 (current LTS). This PR provides a very minimal fix for this by:I know this is not a perfect fix by any means. However, it is sufficient for me to successfully use whipper and I could find it in 3mins of looking. I really don't know anything about whipper and not much about
distutilsor how to replace its deprecated functionality properly.Partially resolves #611
Anyone else who stumbles upon this: If you don't run whipper in a virtualenv (e.g. if you installed it via
apt), it is enough to just delete the import at the top of the file. Just edit the last file mentioned in the error message (at/usr/lib/python3/dist-packages/whipper/command/main.pyfor me) and delete the linefrom distutils.sysconfig import get_python_lib(around line 10).