feat: check for outdated props after first render#75
Merged
maartenbreddels merged 4 commits intomasterfrom Jan 16, 2025
Merged
Conversation
If children or props were updated while the first render's async function resolutions were still settling, the change would not be reflected in the front-end until the next rerender.
maartenbreddels
force-pushed
the
feat-check-outdated-first-render
branch
from
604b035 to
65ad8f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If children or props were updated while the first render's async function resolutions were still settling, the change would not be reflected in the front-end until the next rerender.
To avoid unnecessary rerenders, we use lodash's
isEqualto determine whether the initial props/children are equal to the ones after the render, and update if not.