cleaning up mah and making attributetype printable#849
Open
mtao wants to merge 4 commits intodeprecatedfrom
Open
cleaning up mah and making attributetype printable#849mtao wants to merge 4 commits intodeprecatedfrom
mtao wants to merge 4 commits intodeprecatedfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
- Coverage 77.16% 77.16% -0.01%
==========================================
Files 480 481 +1
Lines 23759 23772 +13
Branches 2656 2656
==========================================
+ Hits 18333 18343 +10
- Misses 5415 5418 +3
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making it so AttributeType is printable and cleaning up some debug in MeshAttribtueHAndle
Also adding a cmake option to enable/disable component unit tests (disabling components turns out to be useful when internet is flaky due to use of wmtk_data repo).