fix: Enable Required toggle and default values for nested object properties#7532
Open
devdattatalele wants to merge 1 commit intowindmill-labs:mainfrom
Open
Conversation
…erties (windmill-labs#7476) This fix propagates isFlowInput/isAppInput flags through EditableSchemaDrawer, PropertyEditor, and FlowPropertyEditor components to enable the Required toggle and default value editor for nested object properties in script parameters. The changes ensure that nested property settings persist correctly and are fully editable in the advanced UI.
devdattatalele
requested review from
alpetric,
hugocasa and
rubenfiszel
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7476
This change enables the Required toggle and default value editor for nested object properties in script parameters. The issue was that EditableSchemaDrawer component lacked the isFlowInput and isAppInput props, which prevented FlowPropertyEditor from being rendered for nested properties.
The fix propagates these flags through EditableSchemaDrawer, PropertyEditor, and FlowPropertyEditor components. This ensures that when users edit nested object properties in the advanced UI settings, they can now set fields as required, configure default values, and use the nullable option to prevent auto-population of empty strings or arrays.
The changes are minimal and focused on prop propagation, maintaining backward compatibility while enabling full editing capabilities for nested properties.