WINDUPRULE-665 Implemented multiple attempts approach#494
WINDUPRULE-665 Implemented multiple attempts approach#494mrizzi wants to merge 5 commits intowindup:masterfrom
Conversation
| urlConn.connect(); | ||
| CACHE_ANALYZED_LINKS.put(link, urlConn.getResponseCode()); | ||
| int attempt = 0; | ||
| while (true) |
There was a problem hiding this comment.
I would recommend not to use this infinite loops. Even you are not specifying the delay between calls, so this is an over-kill.
You can use Awaitily to do this kind of checks where you have a max time or max retries to consider a process Success, and also you can define the delay between attempts.
We already use that in xavier-integration/EndToEndTests : https://github.com/project-xavier/xavier-integration/blob/9b01b4c1a932c16976b38f476a41a0d2bb799bcd/src/test/java/org/jboss/xavier/integrations/EndToEndTest.java#L596
|
@jonathanvila I tried to adopt Awaitility as you suggested. |
|
retest |
|
test comment |
|
retest |
3 participants
https://issues.redhat.com/browse/WINDUPRULE-665
Basic retry implementation without sleep cycle to check if it's just really a temporary failure.
[UPDATED]
It must re-enable the test temporary excluded in #499