chore: rename WireLogging to WireLegacyLogging - WPB-14876#3813
Open
chore: rename WireLogging to WireLegacyLogging - WPB-14876#3813
Conversation
caldrian
force-pushed
the
chore/rename-wirelogging-to-wirelegacylogging-WPB-14876
branch
3 times, most recently
from
0cdb65e to
98bd690
Compare
caldrian
force-pushed
the
chore/rename-wirelogging-to-wirelegacylogging-WPB-14876
branch
2 times, most recently
from
c4b20f6 to
bc48a93
Compare
Contributor
Test Results 17 files 1 205 suites 12m 37s ⏱️ For more details on these failures, see this check. Results for commit 145b7d8. ♻️ This comment has been updated with latest results. |
caldrian
force-pushed
the
chore/rename-wirelogging-to-wirelegacylogging-WPB-14876
branch
from
bc48a93 to
e6e68d2
Compare
caldrian
force-pushed
the
chore/rename-wirelogging-to-wirelegacylogging-WPB-14876
branch
from
e6e68d2 to
02bf0b5
Compare
caldrian
changed the title
…t-warnings-as-errors-WPB-11987
caldrian
changed the base branch from
develop
to
chore/treat-warnings-as-errors-WPB-11987
…me-wirelogging-to-wirelegacylogging-WPB-14876 # Conflicts: # wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj
caldrian
requested review from
Copilot and
netbe
and removed request for
netbe
caldrian
changed the title
caldrian
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a systematic renaming of WireLogging to WireLegacyLogging as the first step in a logging refactoring effort. The change creates a new WireLegacyLogging target/package while preserving the existing WireLogging infrastructure, allowing for a gradual migration to a new logging interface.
Key Changes:
- Creates new
WireLegacyLoggingandWireLegacyLoggingSupporttargets in the WireLogging package - Adds adapter files (
WireLegacyLogging.swift) across modules to provide typealiases fromWireLegacyLoggingmodule - Updates project dependencies from
WireLoggingtoWireLegacyLoggingin pbxproj and Package.swift files - Migrates existing logging code into the new
WireLegacyLoggingtarget - Updates test plans and schemes to include new targets
Reviewed changes
Copilot reviewed 59 out of 68 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| WireLogging/Package.swift | Adds new WireLegacyLogging and WireLegacyLoggingSupport products and targets |
| WireLogging/Sources/WireLegacyLogging/* | New source files for the legacy logging implementation |
| Multiple WireLegacyLogging.swift files | Adapter files providing typealiases to bridge to the new module |
| Multiple .pbxproj files | Updates framework/package references from WireLogging to WireLegacyLogging |
| Multiple Package.swift files | Updates dependencies to use WireLegacyLogging product |
| Test plans and schemes | Updates to include new WireLegacyLogging test targets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
caldrian
changed the title
caldrian
changed the title
zenkins
previously approved these changes
Dec 2, 2025
Collaborator
zenkins
left a comment
zenkins
left a comment
There was a problem hiding this comment.
✅ Auto-approved cherry-pick PR 🍒.
netbe
approved these changes
Dec 12, 2025
…me-wirelogging-to-wirelegacylogging-WPB-14876 # Conflicts: # wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj # wire-ios-request-strategy/WireRequestStrategy.xcodeproj/project.pbxproj # wire-ios-sync-engine/WireSyncEngine.xcodeproj/project.pbxproj
Contributor
|
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
…me-wirelogging-to-wirelegacylogging-WPB-14876 # Conflicts: # wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj # wire-ios-notification-engine/WireNotificationEngine.xcodeproj/project.pbxproj # wire-ios-request-strategy/WireRequestStrategy.xcodeproj/project.pbxproj # wire-ios-sync-engine/WireSyncEngine.xcodeproj/project.pbxproj # wire-ios-transport/WireTransport.xcodeproj/project.pbxproj # wire-ios/Wire-iOS.xcodeproj/project.pbxproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
This is the first PR in a series, the next one is: #3849
As a first step to refactoring the logging this PR moves all existing code from
WireLogginginto a new targetWireLegacyLogging.Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: