fix: Banner Text content is not read aloud merge in to release branch - WPB-14755#4222
Open
SyamalaHari wants to merge 1 commit intorelease/cycle-4.15from
Open
Conversation
SyamalaHari
changed the title
SyamalaHari
changed the title
Contributor
Test Results 3 files 363 suites 3m 32s ⏱️ For more details on these failures, see this check. Results for commit 47d7b1b. Summary: workflow run #21477980899 |
samwyndham
approved these changes
Feb 4, 2026
Contributor
samwyndham
left a comment
samwyndham
left a comment
There was a problem hiding this comment.
LGTM. This is a cherry pick of #4166 right?
netbe
approved these changes
Feb 6, 2026
Collaborator
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
LGTM, left a question though
| ].joined(separator: " ") | ||
|
|
||
| accessibilityIdentifier = "ClassificationBanner" + classification.accessibilitySuffix | ||
| accessibilityIdentifier = Locators.SecurityLevelView.classificationBanner.rawValue + classification |
Collaborator
There was a problem hiding this comment.
question: what's the classification suffix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Issue: The banner "SICHERHEITSNIVEAU:VS-NfD" is not read by the screen reader.
Solution: Added accessibility label for securityLevelLabel as it is a custom UIView
Note: Grouped Accessibility Strings for better maintenance and gave unique name to Accessibility Identifier. Changed this value as this value is currently not used in any UI tests
Testing
When Accessibility is turned on for voice over, the banner text is read out loudly and we can also see accessibility label value when inspected in Accessibility Inspector
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: