fix: remove underline for mentions of own messages in chat bubbles - WPB-20367#4226
Open
SyamalaHari wants to merge 1 commit intorelease/cycle-4.15from
Conversation
Contributor
Test Results 2 files 354 suites 2m 45s ⏱️ For more details on these failures, see this check. Results for commit 60c08f4. Summary: workflow run #21481352352 |
Contributor
|
@SyamalaHari Is this the same as #4149 but targeting a different branch? |
Collaborator
Author
Yes thank you :) |
samwyndham
approved these changes
Feb 6, 2026
Contributor
samwyndham
left a comment
samwyndham
left a comment
There was a problem hiding this comment.
LGTM - this is a cherry pick of #4149
netbe
changed the title
netbe
approved these changes
Feb 6, 2026
Collaborator
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
approved, but left a question to better understand
| guard linkRange.location + linkRange.length <= mutableAttributedText.length else { continue } | ||
|
|
||
| // IMPORTANT: Check for overlap with mentions. | ||
| // If a detected link overlaps with a mention, the mention's styling should take precedence. |
Collaborator
There was a problem hiding this comment.
question: could you give a concrete example? I have hard time to understand this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixing two issues:
Fix: Mentions in chat bubbles should not be underlined
Improvement: Links in chat bubbles of others messages should be underlined
Solution: Removed globally applying link attributes and applying individually to links and mentions
Testing
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: